* [PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata
@ 2017-10-10 13:32 Ladislav Michl
2017-10-13 12:06 ` Roger Quadros
2017-10-14 15:11 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Ladislav Michl @ 2017-10-10 13:32 UTC (permalink / raw)
To: linux-mtd; +Cc: Boris Brezillon, Richard Weinberger, linux-omap
commit 67ce04bf2746 ("mtd: nand: add OMAP2/OMAP3 NAND driver") assigned
pointer to omap_nand_info to the platform drvdata in probe function
just to be reasigned later to the pointer to mtd_info, which is
what remove function expects it to be. Remove useless assignment.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
drivers/mtd/nand/omap2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 01368a8f9e3f..a97c1aeed55e 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1823,7 +1823,6 @@ static int omap_nand_probe(struct platform_device *pdev)
if (err)
return err;
- platform_set_drvdata(pdev, info);
info->ops = gpmc_omap_get_nand_ops(&info->reg, info->gpmc_cs);
if (!info->ops) {
dev_err(&pdev->dev, "Failed to get GPMC->NAND interface\n");
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata
2017-10-10 13:32 [PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata Ladislav Michl
@ 2017-10-13 12:06 ` Roger Quadros
2017-10-14 15:11 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2017-10-13 12:06 UTC (permalink / raw)
To: Ladislav Michl, linux-mtd; +Cc: Boris Brezillon, Richard Weinberger, linux-omap
Hi,
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 10/10/17 16:32, Ladislav Michl wrote:
> commit 67ce04bf2746 ("mtd: nand: add OMAP2/OMAP3 NAND driver") assigned
> pointer to omap_nand_info to the platform drvdata in probe function
> just to be reasigned later to the pointer to mtd_info, which is
> what remove function expects it to be. Remove useless assignment.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Tested on dra7-evm.
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 01368a8f9e3f..a97c1aeed55e 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1823,7 +1823,6 @@ static int omap_nand_probe(struct platform_device *pdev)
> if (err)
> return err;
>
> - platform_set_drvdata(pdev, info);
> info->ops = gpmc_omap_get_nand_ops(&info->reg, info->gpmc_cs);
> if (!info->ops) {
> dev_err(&pdev->dev, "Failed to get GPMC->NAND interface\n");
>
--
cheers,
-roger
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata
2017-10-10 13:32 [PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata Ladislav Michl
2017-10-13 12:06 ` Roger Quadros
@ 2017-10-14 15:11 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-10-14 15:11 UTC (permalink / raw)
To: Ladislav Michl; +Cc: linux-mtd, linux-omap, Richard Weinberger
On Tue, 10 Oct 2017 15:32:45 +0200
Ladislav Michl <ladis@linux-mips.org> wrote:
> commit 67ce04bf2746 ("mtd: nand: add OMAP2/OMAP3 NAND driver") assigned
> pointer to omap_nand_info to the platform drvdata in probe function
> just to be reasigned later to the pointer to mtd_info, which is
> what remove function expects it to be. Remove useless assignment.
>
Applied.
Thanks,
Boris
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
> drivers/mtd/nand/omap2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 01368a8f9e3f..a97c1aeed55e 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1823,7 +1823,6 @@ static int omap_nand_probe(struct platform_device *pdev)
> if (err)
> return err;
>
> - platform_set_drvdata(pdev, info);
> info->ops = gpmc_omap_get_nand_ops(&info->reg, info->gpmc_cs);
> if (!info->ops) {
> dev_err(&pdev->dev, "Failed to get GPMC->NAND interface\n");
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-14 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-10 13:32 [PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata Ladislav Michl
2017-10-13 12:06 ` Roger Quadros
2017-10-14 15:11 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox