* Re: [PATCH][next] mtd: nand: fix spelling mistake: "suceed"-> "succeed"
[not found] ` <5A5DDCA0.1000908@bfs.de>
@ 2018-01-19 7:39 ` Miquel Raynal
0 siblings, 0 replies; only message in thread
From: Miquel Raynal @ 2018-01-19 7:39 UTC (permalink / raw)
To: walter harms
Cc: kernel-janitors, Colin King, Boris Brezillon, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Cyrille Pitchen,
linux-mtd
Hello,
Can you please change the prefix, it should be:
mtd: nand: marvell:
On Tue, 16 Jan
2018 12:06:08 +0100 walter harms <wharms@bfs.de> wrote:
> Am 16.01.2018 11:28, schrieb Colin King:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Trivial fix to spelling mistakes in dev_err error message text.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/mtd/nand/marvell_nand.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/marvell_nand.c
> > b/drivers/mtd/nand/marvell_nand.c index b8fec6093b75..4bd53b360277
> > 100644 --- a/drivers/mtd/nand/marvell_nand.c
> > +++ b/drivers/mtd/nand/marvell_nand.c
> > @@ -517,7 +517,7 @@ static int marvell_nfc_prepare_cmd(struct
> > nand_chip *chip) /* Poll ND_RUN and clear NDSR before issuing any
> > command */ ret = marvell_nfc_wait_ndrun(chip);
> > if (ret) {
> > - dev_err(nfc->dev, "Last operation did not
> > suceed\n");
> > + dev_err(nfc->dev, "Last operation did not
> > succeed\n"); return ret;
> > }
> >
>
> not succeed == Failed ??
I personally do not have a preference, as long as there is a clear
error message in this case.
> someone who is debugging may also interessted to know what operation
> failed.
It is not as easy to do, but starting from enabling dynamic debug in
both the driver and the NAND core should give you enough traces to
locate the issue.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] only message in thread