* [PATCH V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list
@ 2023-06-02 21:56 Rafał Miłecki
2023-06-03 10:10 ` Conor Dooley
2023-06-09 15:27 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Rafał Miłecki @ 2023-06-02 21:56 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Pratyush Yadav, Dhruva Gole, linux-mtd, devicetree,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
It's supposed to be there and it's needed for proper validation of DTS
files.
This fixes following errors for Northstar based TP-Link routers:
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: 'oneOf' conditional failed, one must be fixed:
'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: 'pinctrl-[0-9]+'
'#address-cells' is a required property
'#size-cells' is a required property
'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+'
'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
'fis-index-block' is a required property
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
['tplink,safeloader-partitions'] is too short
'fixed-partitions' was expected
'sercomm,sc-partitions' was expected
'arm,arm-firmware-suite' was expected
'brcm,bcm4908-partitions' was expected
'brcm,bcm947xx-cfe-partitions' was expected
'linksys,ns-partitions' was expected
'qcom,smem-part' was expected
'redboot-fis' was expected
From schema: Documentation/devicetree/bindings/mtd/mtd.yaml
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: Unevaluated properties are not allowed ('partitions-table-offset' was unexpected)
From schema: Documentation/devicetree/bindings/mtd/mtd.yaml
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: 'oneOf' conditional failed, one must be fixed:
'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: 'pinctrl-[0-9]+'
'#address-cells' is a required property
'#size-cells' is a required property
'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+'
'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
'fis-index-block' is a required property
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
['tplink,safeloader-partitions'] is too short
'fixed-partitions' was expected
'sercomm,sc-partitions' was expected
'arm,arm-firmware-suite' was expected
'brcm,bcm4908-partitions' was expected
'brcm,bcm947xx-cfe-partitions' was expected
'linksys,ns-partitions' was expected
'qcom,smem-part' was expected
'redboot-fis' was expected
From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: Unevaluated properties are not allowed ('partitions-table-offset' was unexpected)
From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: Unevaluated properties are not allowed ('partitions' was unexpected)
From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
V2: Include example of errors this fixes
---
Documentation/devicetree/bindings/mtd/partitions/partitions.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
index 2edc65e0e361..1dda2c80747b 100644
--- a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
+++ b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml
@@ -21,6 +21,7 @@ oneOf:
- $ref: linksys,ns-partitions.yaml
- $ref: qcom,smem-part.yaml
- $ref: redboot-fis.yaml
+ - $ref: tplink,safeloader-partitions.yaml
properties:
compatible: true
--
2.35.3
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list
2023-06-02 21:56 [PATCH V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list Rafał Miłecki
@ 2023-06-03 10:10 ` Conor Dooley
2023-06-09 15:27 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-06-03 10:10 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Pratyush Yadav,
Dhruva Gole, linux-mtd, devicetree, Rafał Miłecki
[-- Attachment #1.1: Type: text/plain, Size: 1148 bytes --]
On Fri, Jun 02, 2023 at 11:56:29PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's supposed to be there and it's needed for proper validation of DTS
> files.
>
> This fixes following errors for Northstar based TP-Link routers:
> bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
> ['tplink,safeloader-partitions'] is too short
> 'fixed-partitions' was expected
> 'sercomm,sc-partitions' was expected
> 'arm,arm-firmware-suite' was expected
> 'brcm,bcm4908-partitions' was expected
> 'brcm,bcm947xx-cfe-partitions' was expected
> 'linksys,ns-partitions' was expected
> 'qcom,smem-part' was expected
> 'redboot-fis' was expected
Something like this would have been sufficient, dumping the whole error
into the commit message bloats it for no real gain, but I was asking for
you to say what the issue was, not asking for a resubmission (yet anyway).
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list
2023-06-02 21:56 [PATCH V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list Rafał Miłecki
2023-06-03 10:10 ` Conor Dooley
@ 2023-06-09 15:27 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2023-06-09 15:27 UTC (permalink / raw)
To: Rafał Miłecki, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Pratyush Yadav, Dhruva Gole, linux-mtd, devicetree,
Rafał Miłecki
On Fri, 2023-06-02 at 21:56:29 UTC, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's supposed to be there and it's needed for proper validation of DTS
> files.
>
> This fixes following errors for Northstar based TP-Link routers:
>
> arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: 'oneOf' conditional failed, one must be fixed:
> 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: 'pinctrl-[0-9]+'
> '#address-cells' is a required property
> '#size-cells' is a required property
> 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
> 'fis-index-block' is a required property
> arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
> ['tplink,safeloader-partitions'] is too short
> 'fixed-partitions' was expected
> 'sercomm,sc-partitions' was expected
> 'arm,arm-firmware-suite' was expected
> 'brcm,bcm4908-partitions' was expected
> 'brcm,bcm947xx-cfe-partitions' was expected
> 'linksys,ns-partitions' was expected
> 'qcom,smem-part' was expected
> 'redboot-fis' was expected
> From schema: Documentation/devicetree/bindings/mtd/mtd.yaml
> arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: Unevaluated properties are not allowed ('partitions-table-offset' was unexpected)
> From schema: Documentation/devicetree/bindings/mtd/mtd.yaml
> arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: 'oneOf' conditional failed, one must be fixed:
> 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: 'pinctrl-[0-9]+'
> '#address-cells' is a required property
> '#size-cells' is a required property
> 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 'partition-file-system', 'partition-os-image', 'partitions-table-offset' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
> 'fis-index-block' is a required property
> arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
> ['tplink,safeloader-partitions'] is too short
> 'fixed-partitions' was expected
> 'sercomm,sc-partitions' was expected
> 'arm,arm-firmware-suite' was expected
> 'brcm,bcm4908-partitions' was expected
> 'brcm,bcm947xx-cfe-partitions' was expected
> 'linksys,ns-partitions' was expected
> 'qcom,smem-part' was expected
> 'redboot-fis' was expected
> From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions: Unevaluated properties are not allowed ('partitions-table-offset' was unexpected)
> From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dtb: flash@0: Unevaluated properties are not allowed ('partitions' was unexpected)
> From schema: Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-09 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 21:56 [PATCH V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list Rafał Miłecki
2023-06-03 10:10 ` Conor Dooley
2023-06-09 15:27 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox