From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Jakub Czapiga <czapiga@google.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: xmc: add support for XM25QH128C and XM25QH256C
Date: Tue, 18 Mar 2025 08:27:09 +0200 [thread overview]
Message-ID: <e2e890a9-ebc4-45fb-92eb-502be027e807@linaro.org> (raw)
In-Reply-To: <20250317182107.2060739-1-czapiga@google.com>
Hi, Jakub,
Do you have access to these flashes? Can you test them?
We have a minimum testing requirement before updating or adding new
flashes, here it is:
https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements
It's true that we don't have yet locking tests described, but
contributions to the documentation is welcomed!
On 17.03.2025 20:21, Jakub Czapiga wrote:
> Both chips support SFDP (JESD216).
> XM25QH128C only supports 3-bit Block-Protection with Top-Bottom
> configuration bit.
> XM25QH256C supports 4-bit Block-Protection with Top-Bottom configuration
> bit on SR(6).
>
> Signed-off-by: Jakub Czapiga <czapiga@google.com>
> ---
> drivers/mtd/spi-nor/xmc.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/xmc.c b/drivers/mtd/spi-nor/xmc.c
> index d5a06054b0dd..963a44c3909a 100644
> --- a/drivers/mtd/spi-nor/xmc.c
> +++ b/drivers/mtd/spi-nor/xmc.c
> @@ -19,7 +19,17 @@ static const struct flash_info xmc_nor_parts[] = {
> .name = "XM25QH128A",
> .size = SZ_16M,
> .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
> - },
> + }, {
> + .id = SNOR_ID(0x20, 0x40, 0x18),
> + .name = "XM25QH128C",
for the next version, drop the name and add it just as a comment above
the flash entry definition
> + .size = SZ_16M,
if flash supports SFDP, drop the size parameter, it will trigger SFDP
parsing.
> + .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
> + }, {
> + .id = SNOR_ID(0x20, 0x40, 0x19),
> + .name = "XM25QH256C",
> + .size = SZ_32M,
> + .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_4BIT_BP | SPI_NOR_TB_SR_BIT6,
same here. After switching to flash init based on SFDP, please do the
tests mentioned above.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-03-18 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 18:21 [PATCH] mtd: spi-nor: xmc: add support for XM25QH128C and XM25QH256C Jakub Czapiga
2025-03-18 6:27 ` Tudor Ambarus [this message]
2025-03-18 11:01 ` Jakub "Kuba" Czapiga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e890a9-ebc4-45fb-92eb-502be027e807@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=czapiga@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox