Re: [PATCH 5/5] mtd: spi-nor: spansion: Add S28HS02GT ID and fixups

[Tudor Ambarus <tudor.ambarus@linaro.org>]

On 6/12/23 11:04, tkuw584924@gmail.com wrote:
> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
> 
> Infineon S28HS02GT is 2Gb, multi-chip package, Octal SPI Flash. This patch
> adds ID table, fix params->n_dice value, and replace params->ready() with
> MCP version.
> 
> Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
> ---
>  drivers/mtd/spi-nor/spansion.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
> index 8b8512402639..88dc849a63b3 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -720,6 +720,10 @@ static int s28hx_t_post_sfdp_fixup(struct spi_nor *nor)

you are modifying all the s28hx_t flashes, yet I don't see anything
mentioned about them in the commit message, why they are still working
and what tests have been done.

>  	 */
>  	nor->params->rdsr_addr_nbytes = 4;
>  
> +	/* The 2 Gb parts duplicate info and advertise 4 dice instead of 2. */
> +	if (nor->params->size == SZ_256M)
> +		nor->params->n_dice = 2;
> +
>  	return cypress_nor_get_page_size(nor);
>  }
>  
> @@ -738,8 +742,15 @@ static int s28hx_t_post_bfpt_fixup(struct spi_nor *nor,
>  
>  static void s28hx_t_late_init(struct spi_nor *nor)
>  {
> -	nor->params->octal_dtr_enable = cypress_nor_octal_dtr_enable;
> +	struct spi_nor_flash_parameter *params = nor->params;
> +
> +	params->octal_dtr_enable = cypress_nor_octal_dtr_enable;
> +
>  	cypress_nor_ecc_init(nor);
> +
> +	/* Replace ready() with multi die version */
> +	if (params->n_dice)
> +		params->ready = cypress_nor_sr_ready_and_clear;
>  }
>  
>  static const struct spi_nor_fixups s28hx_t_fixups = {
> @@ -913,6 +924,11 @@ static const struct flash_info spansion_nor_parts[] = {
>  		MFR_FLAGS(USE_CLPEF)
>  		.fixups = &s28hx_t_fixups,
>  	},
> +	{ "s28hs02gt",   INFO(0x345b1c,      0, 256 * 1024, 1024)
> +		PARSE_SFDP
> +		MFR_FLAGS(USE_CLPEF)
> +		.fixups = &s28hx_t_fixups,
> +	},
>  };
>  
>  /**

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/