From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Michael Walle <michael@walle.cc>, liao jaime <jaimeliao.tw@gmail.com>
Cc: linux-mtd@lists.infradead.org, pratyush@kernel.org,
miquel.raynal@bootlin.com, leoyu@mxic.com.tw,
jaimeliao@mxic.com.tw
Subject: Re: [PATCH v5 6/6] mtd: spi-nor: add support for Macronix Octal flash
Date: Tue, 21 Nov 2023 09:09:45 +0000 [thread overview]
Message-ID: <fb66cdb7-e89e-47a0-96ef-022a512ceebb@linaro.org> (raw)
In-Reply-To: <844becc9c6fde66c4d60a621b5462998@walle.cc>
On 11/21/23 08:51, Michael Walle wrote:
> Hi Jaime,
>
> [please keep the CC list in replies].
>
>>> and sometimes incorrect. Therefore, at least drop it and just list the
>>> IDs.
>> Could I know patch 6/6 only or patch 5/6 should remove name as well?
>
> I'd say yes. Tudor? Pratyush? New flash additions without names?
Why do you need a flash addition in the first place? Haven't we agreed
that we'll apply the vendor fixup based on the manufacturer ID?
Anyway, flash additions without names is fine by me.
Cheers,
ta
>
> As, mentioned last time, for OF we might introduce an of_compatible
> (thats then ABI) - or - we can use the numeric ID in the device tree,
> as it's already used for PHY IDs or PCI IDs.
>
> Jaime, could you try to use
>
> /* Apply vendor fixups */
> { .id = SNOR_ID(0xc2) }
>
> -michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-11-21 9:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 8:38 [PATCH v5 0/6] Add octal DTR support for Macronix flash Jaime Liao
2023-11-17 8:38 ` [PATCH v5 1/6] mtd: spi-nor: add Octal " Jaime Liao
2023-11-17 8:38 ` [PATCH v5 2/6] spi: spi-mem: Allow specifying the byte order in DTR mode Jaime Liao
2023-11-17 9:17 ` Tudor Ambarus
2023-11-17 10:00 ` liao jaime
2023-11-17 8:38 ` [PATCH v5 3/6] mtd: spi-nor: core: " Jaime Liao
2023-11-21 8:40 ` Michael Walle
2023-11-21 9:53 ` liao jaime
2023-11-17 8:38 ` [PATCH v5 4/6] mtd: spi-nor: sfdp: Get the 8D-8D-8D byte order from BFPT Jaime Liao
2023-11-17 8:38 ` [PATCH v5 5/6] mtd: spi-nor: add support for Macronix Octal flash with RWW feature Jaime Liao
2023-11-17 9:21 ` Tudor Ambarus
2023-11-17 10:01 ` liao jaime
2023-11-17 8:38 ` [PATCH v5 6/6] mtd: spi-nor: add support for Macronix Octal flash Jaime Liao
2023-11-17 8:57 ` Michael Walle
2023-11-17 9:05 ` Tudor Ambarus
[not found] ` <CAAQoYRkw5hUONJ32sGKxgv5XtO24Vc6=KojankTG73u5E7jPBw@mail.gmail.com>
2023-11-21 8:51 ` Michael Walle
2023-11-21 9:09 ` Tudor Ambarus [this message]
2023-11-22 3:15 ` liao jaime
2023-11-22 10:16 ` Michael Walle
2023-11-17 9:23 ` Tudor Ambarus
2023-11-17 8:48 ` [PATCH v5 0/6] Add octal DTR support for Macronix flash Michael Walle
2023-11-17 10:09 ` liao jaime
2023-11-17 10:26 ` Michael Walle
2023-11-20 1:50 ` liao jaime
2023-11-21 8:29 ` Michael Walle
2023-11-21 8:32 ` liao jaime
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb66cdb7-e89e-47a0-96ef-022a512ceebb@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=jaimeliao.tw@gmail.com \
--cc=jaimeliao@mxic.com.tw \
--cc=leoyu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox