* [PATCH virtio] pds_vdpa: protect Makefile from unconfigured debugfs
@ 2023-07-06 23:17 Shannon Nelson
2023-07-06 23:26 ` Randy Dunlap
2023-07-10 3:16 ` Jason Wang
0 siblings, 2 replies; 3+ messages in thread
From: Shannon Nelson @ 2023-07-06 23:17 UTC (permalink / raw)
To: rdunlap, jasowang, mst, virtualization, shannon.nelson,
brett.creeley
Cc: netdev, drivers, sfr, linux-next, linux-kernel
debugfs.h protects itself from an undefined DEBUG_FS, so it is
not necessary to check it in the driver code or the Makefile.
The driver code had been updated for this, but the Makefile had
missed the update.
Link: https://lore.kernel.org/linux-next/fec68c3c-8249-7af4-5390-0495386a76f9@infradead.org/
Fixes: a16291b5bcbb ("pds_vdpa: Add new vDPA driver for AMD/Pensando DSC")
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
---
drivers/vdpa/pds/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/vdpa/pds/Makefile b/drivers/vdpa/pds/Makefile
index 2e22418e3ab3..c2d314d4614d 100644
--- a/drivers/vdpa/pds/Makefile
+++ b/drivers/vdpa/pds/Makefile
@@ -5,6 +5,5 @@ obj-$(CONFIG_PDS_VDPA) := pds_vdpa.o
pds_vdpa-y := aux_drv.o \
cmds.o \
+ debugfs.o \
vdpa_dev.o
-
-pds_vdpa-$(CONFIG_DEBUG_FS) += debugfs.o
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH virtio] pds_vdpa: protect Makefile from unconfigured debugfs
2023-07-06 23:17 [PATCH virtio] pds_vdpa: protect Makefile from unconfigured debugfs Shannon Nelson
@ 2023-07-06 23:26 ` Randy Dunlap
2023-07-10 3:16 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-07-06 23:26 UTC (permalink / raw)
To: Shannon Nelson, jasowang, mst, virtualization, brett.creeley
Cc: netdev, drivers, sfr, linux-next, linux-kernel
On 7/6/23 16:17, Shannon Nelson wrote:
> debugfs.h protects itself from an undefined DEBUG_FS, so it is
> not necessary to check it in the driver code or the Makefile.
> The driver code had been updated for this, but the Makefile had
> missed the update.
>
> Link: https://lore.kernel.org/linux-next/fec68c3c-8249-7af4-5390-0495386a76f9@infradead.org/
> Fixes: a16291b5bcbb ("pds_vdpa: Add new vDPA driver for AMD/Pensando DSC")
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/vdpa/pds/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/pds/Makefile b/drivers/vdpa/pds/Makefile
> index 2e22418e3ab3..c2d314d4614d 100644
> --- a/drivers/vdpa/pds/Makefile
> +++ b/drivers/vdpa/pds/Makefile
> @@ -5,6 +5,5 @@ obj-$(CONFIG_PDS_VDPA) := pds_vdpa.o
>
> pds_vdpa-y := aux_drv.o \
> cmds.o \
> + debugfs.o \
> vdpa_dev.o
> -
> -pds_vdpa-$(CONFIG_DEBUG_FS) += debugfs.o
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH virtio] pds_vdpa: protect Makefile from unconfigured debugfs
2023-07-06 23:17 [PATCH virtio] pds_vdpa: protect Makefile from unconfigured debugfs Shannon Nelson
2023-07-06 23:26 ` Randy Dunlap
@ 2023-07-10 3:16 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2023-07-10 3:16 UTC (permalink / raw)
To: Shannon Nelson
Cc: rdunlap, mst, virtualization, brett.creeley, netdev, drivers, sfr,
linux-next, linux-kernel
On Fri, Jul 7, 2023 at 7:17 AM Shannon Nelson <shannon.nelson@amd.com> wrote:
>
> debugfs.h protects itself from an undefined DEBUG_FS, so it is
> not necessary to check it in the driver code or the Makefile.
> The driver code had been updated for this, but the Makefile had
> missed the update.
>
> Link: https://lore.kernel.org/linux-next/fec68c3c-8249-7af4-5390-0495386a76f9@infradead.org/
> Fixes: a16291b5bcbb ("pds_vdpa: Add new vDPA driver for AMD/Pensando DSC")
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
> ---
> drivers/vdpa/pds/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/pds/Makefile b/drivers/vdpa/pds/Makefile
> index 2e22418e3ab3..c2d314d4614d 100644
> --- a/drivers/vdpa/pds/Makefile
> +++ b/drivers/vdpa/pds/Makefile
> @@ -5,6 +5,5 @@ obj-$(CONFIG_PDS_VDPA) := pds_vdpa.o
>
> pds_vdpa-y := aux_drv.o \
> cmds.o \
> + debugfs.o \
> vdpa_dev.o
> -
> -pds_vdpa-$(CONFIG_DEBUG_FS) += debugfs.o
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-10 3:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-06 23:17 [PATCH virtio] pds_vdpa: protect Makefile from unconfigured debugfs Shannon Nelson
2023-07-06 23:26 ` Randy Dunlap
2023-07-10 3:16 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox