linux-next: unsigned commit ...

linux-next: unsigned commit ...

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi James,

Commit 676dac4b1bee0469d6932f698aeb77e8489f5861 ("This patch adds a new
security attribute to Smack called") that was added to your tree today
has no Signed-off-by and could do with a better summary line in the
commit message.  And probably a better explanation of what it does.

Makes me wonder about the level of review it received :-(

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: unsigned commit ...

[Casey Schaufler]

The problem was in my converting to a git based submission
process, not with the level of review, although I can see how
the two would be indistinguishable. Thank you for the follow-up.


On 12/2/2010 2:29 PM, Stephen Rothwell wrote:
> Hi James,
>
> Commit 676dac4b1bee0469d6932f698aeb77e8489f5861 ("This patch adds a new
> security attribute to Smack called") that was added to your tree today
> has no Signed-off-by and could do with a better summary line in the
> commit message.  And probably a better explanation of what it does.
>
> Makes me wonder about the level of review it received :-(
>

Re: linux-next: unsigned commit ...

[James Morris]

On Fri, 3 Dec 2010, Stephen Rothwell wrote:

> Hi James,
> 
> Commit 676dac4b1bee0469d6932f698aeb77e8489f5861 ("This patch adds a new
> security attribute to Smack called") that was added to your tree today
> has no Signed-off-by and could do with a better summary line in the
> commit message.  And probably a better explanation of what it does.
> 
> Makes me wonder about the level of review it received :-(

I noticed it and pointed it out to Casey, who is converting over to 
pushing git to me instead of posting patch sets.

If I'm pulling from someone's repo, it means I trust them enough not to 
need to personally review each line of change.

Can this be fixed with git-commit --amend ?



- James
-- 
James Morris
<jmorris@namei.org>

Re: linux-next: unsigned commit ...

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

Hi James,

On Fri, 3 Dec 2010 12:21:00 +1100 (EST) James Morris <jmorris@namei.org> wrote:
>
> On Fri, 3 Dec 2010, Stephen Rothwell wrote:
> 
> I noticed it and pointed it out to Casey, who is converting over to 
> pushing git to me instead of posting patch sets.

OK, so learning, I guess.

> If I'm pulling from someone's repo, it means I trust them enough not to 
> need to personally review each line of change.
> 
> Can this be fixed with git-commit --amend ?

In Casey's tree it can.  But then you would need to remerge his tree into
yours.  That would leave us with both versions of the commit in your tree.

If, however, you first do a "git reset --hard HEAD^" on your tree
(assuming that the old merge is still at the top), then it will be like
the old merge was never done.   This, however will disrupt anyone who's
tree is built on top of yours and has merged your tree (or rebased on top
of it) while that old merge was there (just like if you rebased your
tree).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]