From: andros@netapp.com
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, pnfs@linux-nfs.org,
Andy Adamson <andros@netapp.com>
Subject: [PATCH 21/29] nfsd41: remove iovlen field from nfsd4_compound_state
Date: Thu, 23 Apr 2009 12:43:00 -0400 [thread overview]
Message-ID: <1240504988-9572-22-git-send-email-andros@netapp.com> (raw)
In-Reply-To: <1240504988-9572-21-git-send-email-andros@netapp.com>
From: Andy Adamson <andros@netapp.com>
Set resp->p in nfsd4_replay_cache_entry so that the nfs4svc_encode_compoundres
iov_len calculation is correct.
Signed-off-by: Andy Adamson <andros@netapp.com>
---
fs/nfsd/nfs4state.c | 1 +
fs/nfsd/nfs4xdr.c | 5 +----
include/linux/nfsd/xdr4.h | 1 -
3 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 8c96451..1affb0a 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1120,6 +1120,7 @@ nfsd4_replay_cache_entry(struct nfsd4_compoundres *resp,
entry->ce_datav.iov_len);
resp->opcnt = entry->ce_opcnt;
+ resp->p = resp->cstate.datap + XDR_QUADLEN(entry->ce_datav.iov_len);
status = entry->ce_status;
return status;
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index f4bba66..1e46525 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -3359,10 +3359,7 @@ nfs4svc_encode_compoundres(struct svc_rqst *rqstp, __be32 *p, struct nfsd4_compo
iov->iov_len = ((char*)resp->p) - (char*)iov->iov_base;
BUG_ON(iov->iov_len > PAGE_SIZE);
if (nfsd4_has_session(&resp->cstate)) {
- if (resp->cstate.status == nfserr_replay_cache &&
- !nfsd4_not_cached(resp)) {
- iov->iov_len = resp->cstate.iovlen;
- } else {
+ if (resp->cstate.status != nfserr_replay_cache) {
/* FIXME: return ignored for now. Can have -ENOMEM */
nfsd4_store_cache_entry(resp);
dprintk("%s: SET SLOT STATE TO AVAILABLE\n", __func__);
diff --git a/include/linux/nfsd/xdr4.h b/include/linux/nfsd/xdr4.h
index 97f5cee..45ccbc3 100644
--- a/include/linux/nfsd/xdr4.h
+++ b/include/linux/nfsd/xdr4.h
@@ -52,7 +52,6 @@ struct nfsd4_compound_state {
struct nfsd4_session *session;
struct nfsd4_slot *slot;
__be32 *datap;
- size_t iovlen;
u32 minorversion;
u32 status;
};
--
1.5.4.3
next prev parent reply other threads:[~2009-04-23 16:43 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 16:42 [PATCH 0/29] NFSv4.1 Server DRC rewrite andros
2009-04-23 16:42 ` [PATCH 01/29] nfsd41: add create session slot buffer to struc nfs4_client andros
2009-04-23 16:42 ` [PATCH 02/29] nfsd41: encode create_session result into cache andros
2009-04-23 16:42 ` [PATCH 03/29] nfsd41: create_session check replay first andros
2009-04-23 16:42 ` [PATCH 04/29] nfsd41: replay solo and embedded create session andros
2009-04-23 16:42 ` [PATCH 05/29] nfsd41: create_session cache hold client reference andros
2009-04-23 16:42 ` [PATCH 06/29] nfsd41: no nfsd4_release_respages for the clientid cache andros
2009-04-23 16:42 ` [PATCH 07/29] nfsd41: slots are freed with session andros
2009-04-23 16:42 ` [PATCH 08/29] nfsd41: protect sv_drc_pages_used with spinlock andros
2009-04-23 16:42 ` [PATCH 09/29] nfsd41: sanity check client drc maxreqs andros
2009-04-23 16:42 ` [PATCH 10/29] nfsd41: change from page to memory based drc limits andros
2009-04-23 16:42 ` [PATCH 11/29] nfsd41: set the session maximum response size cached andros
2009-04-23 16:42 ` [PATCH 12/29] nfsd41: allocate and use drc cache buffers andros
2009-04-23 16:42 ` [PATCH 13/29] nfsd41: free " andros
2009-04-23 16:42 ` [PATCH 14/29] nfsd41: obliterate nfsd4_copy_pages andros
2009-04-23 16:42 ` [PATCH 15/29] nfsd41: obliterate nfsd41_copy_replay_data andros
2009-04-23 16:42 ` [PATCH 16/29] nfsd41: obliterate nfsd4_release_respages andros
2009-04-23 16:42 ` [PATCH 17/29] nfsd41: remove unused nfsd4_cache_entry fields andros
2009-04-23 16:42 ` [PATCH 18/29] nfsd41: obliterate nfsd4_set_statp andros
2009-04-23 16:42 ` [PATCH 19/29] nfsd41: rename nfsd4_enc_uncached_replay andros
2009-04-23 16:42 ` [PATCH 20/29] nfsd41: encode replay sequence from the slot values andros
2009-04-23 16:43 ` andros [this message]
2009-04-23 16:43 ` [PATCH 22/29] nfsd41: obliterate nfsd41_copy_replay_data andros
2009-04-23 16:43 ` [PATCH 23/29] nfsd41: fix nfsd4_store_cache_entry comments andros
2009-04-23 16:43 ` [PATCH 24/29] nfsd41: support 16 slots per session andros
2009-04-23 16:43 ` [PATCH 25/29] nfsd41: use the maximum operations per compound in nfsd4_compoundargs andros
2009-04-23 16:43 ` [PATCH 26/29] nfsd41: fix nfsd4_store_cache_entry dprintk andros
2009-04-23 16:43 ` [PATCH 27/29] nfsd41: add test for failed sequence operation andros
2009-04-23 16:43 ` [PATCH 28/29] nfsd41: remove redundant failed sequence check andros
2009-04-23 16:43 ` [PATCH 29/29] nfsd41: remove check for session andros
2009-04-23 23:39 ` [PATCH 13/29] nfsd41: free drc cache buffers J. Bruce Fields
2009-04-24 14:11 ` [pnfs] " William A. (Andy) Adamson
2009-04-23 23:36 ` [PATCH 08/29] nfsd41: protect sv_drc_pages_used with spinlock J. Bruce Fields
2009-04-24 14:11 ` [pnfs] " William A. (Andy) Adamson
2009-04-23 23:28 ` [PATCH 05/29] nfsd41: create_session cache hold client reference J. Bruce Fields
2009-04-24 13:52 ` Andy Adamson
2009-04-24 14:02 ` J. Bruce Fields
2009-04-24 14:06 ` [pnfs] " William A. (Andy) Adamson
2009-04-23 23:25 ` [PATCH 04/29] nfsd41: replay solo and embedded create session J. Bruce Fields
2009-04-23 23:21 ` [PATCH 02/29] nfsd41: encode create_session result into cache J. Bruce Fields
2009-04-23 23:32 ` J. Bruce Fields
2009-04-24 13:56 ` Andy Adamson
2009-04-24 13:52 ` Andy Adamson
2009-04-23 22:55 ` [PATCH 01/29] nfsd41: add create session slot buffer to struc nfs4_client J. Bruce Fields
2009-04-23 23:41 ` [PATCH 0/29] NFSv4.1 Server DRC rewrite J. Bruce Fields
2009-04-24 14:12 ` [pnfs] " William A. (Andy) Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240504988-9572-22-git-send-email-andros@netapp.com \
--to=andros@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox