public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: andros@netapp.com
Cc: linux-nfs@vger.kernel.org, pnfs@linux-nfs.org
Subject: Re: [PATCH 0/29] NFSv4.1 Server DRC rewrite
Date: Thu, 23 Apr 2009 19:41:15 -0400	[thread overview]
Message-ID: <20090423234115.GO1906@fieldses.org> (raw)
In-Reply-To: <1240504988-9572-1-git-send-email-andros@netapp.com>

On Thu, Apr 23, 2009 at 12:42:39PM -0400, andros@netapp.com wrote:
> This is a rewrite of the NFSv4.1 DRC, switching from a page based cache to
> a buffer based cache. The logic for the single slot clientid cache has been
> separated from the session slot logic to handle the CREATE_SESSION call
> preceeded by a SEQUENCE and all the replay combinations therein.
> 
> The session DRC now caches encoded operations with the exception of the
> SEQUENCE operation which for a replay is encoded with the current slot and
> session values.  A review of message sizes indicates that a 1024 byte buffer
> for the operations is more than adequate.

Thanks, a quick skim suggests the basic idea's right.... I may not get
around to looking at this closer soon; let me know if there's a new
version at some point.

--b.

> 
> Not addressed is the necessary pre-operation processing estimate of the encoded
> per operation result to check against the negotiated fore channel maximum
> response size cached.
> 
> I've tested NFSv4.1 mounts using Connectathon and the new pynfs 4.1 tests,
> where I added two new Clientid cache replay tests [to be submitted]to
> st_create_session.py.
> 
> I've tested NFSv4.0 mounts using Connectathon and the pynfs v4.0 tests.
> 
> As always, comments and suggestions welcome.
> 
> -->Andy
> 
> Clientid single slot cache
> 0001-nfsd41-add-create-session-slot-buffer-to-struc-nfs4.patch
> 0002-nfsd41-encode-create_session-result-into-cache.patch
> 0003-nfsd41-create_session-check-replay-first.patch
> 0004-nfsd41-replay-solo-and-embedded-create-session.patch
> 0005-nfsd41-create_session-cache-hold-client-reference.patch
> 0006-nfsd41-no-nfsd4_release_respages-for-the-clientid-c.patch
> 0007-nfsd41-slots-are-freed-with-session.patch
> 
> Session slot cache
> 0008-nfsd41-protect-sv_drc_pages_used-with-spinlock.patch
> 0009-nfsd41-sanity-check-client-drc-maxreqs.patch
> 0010-nfsd41-change-from-page-to-memory-based-drc-limits.patch
> 0011-nfsd41-set-the-session-maximum-response-size-cached.patch
> 0012-nfsd41-allocate-and-use-drc-cache-buffers.patch
> 0013-nfsd41-free-drc-cache-buffers.patch
> 0014-nfsd41-obliterate-nfsd4_copy_pages.patch
> 0015-nfsd41-obliterate-nfsd41_copy_replay_data.patch
> 0016-nfsd41-obliterate-nfsd4_release_respages.patch
> 0017-nfsd41-remove-unused-nfsd4_cache_entry-fields.patch
> 0018-nfsd41-obliterate-nfsd4_set_statp.patch
> 0019-nfsd41-rename-nfsd4_enc_uncached_replay.patch
> 0020-nfsd41-encode-replay-sequence-from-the-slot-values.patch
> 0021-nfsd41-remove-iovlen-field-from-nfsd4_compound_stat.patch
> 0022-nfsd41-obliterate-nfsd41_copy_replay_data.patch
> 0023-nfsd41-fix-nfsd4_store_cache_entry-comments.patch
> 0024-nfsd41-support-16-slots-per-session.patch
> 0025-nfsd41-use-the-maximum-operations-per-compound-in-n.patch
> 0026-nfsd41-fix-nfsd4_store_cache_entry-dprintk.patch
> 0027-nfsd41-add-test-for-failed-sequence-operation.patch
> 0028-nfsd41-remove-redundant-failed-sequence-check.patch
> 0029-nfsd41-remove-check-for-session.patch
> 
> 

  parent reply	other threads:[~2009-04-23 23:41 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 16:42 [PATCH 0/29] NFSv4.1 Server DRC rewrite andros
2009-04-23 16:42 ` [PATCH 01/29] nfsd41: add create session slot buffer to struc nfs4_client andros
2009-04-23 16:42   ` [PATCH 02/29] nfsd41: encode create_session result into cache andros
2009-04-23 16:42     ` [PATCH 03/29] nfsd41: create_session check replay first andros
2009-04-23 16:42       ` [PATCH 04/29] nfsd41: replay solo and embedded create session andros
2009-04-23 16:42         ` [PATCH 05/29] nfsd41: create_session cache hold client reference andros
2009-04-23 16:42           ` [PATCH 06/29] nfsd41: no nfsd4_release_respages for the clientid cache andros
2009-04-23 16:42             ` [PATCH 07/29] nfsd41: slots are freed with session andros
2009-04-23 16:42               ` [PATCH 08/29] nfsd41: protect sv_drc_pages_used with spinlock andros
2009-04-23 16:42                 ` [PATCH 09/29] nfsd41: sanity check client drc maxreqs andros
2009-04-23 16:42                   ` [PATCH 10/29] nfsd41: change from page to memory based drc limits andros
2009-04-23 16:42                     ` [PATCH 11/29] nfsd41: set the session maximum response size cached andros
2009-04-23 16:42                       ` [PATCH 12/29] nfsd41: allocate and use drc cache buffers andros
2009-04-23 16:42                         ` [PATCH 13/29] nfsd41: free " andros
2009-04-23 16:42                           ` [PATCH 14/29] nfsd41: obliterate nfsd4_copy_pages andros
2009-04-23 16:42                             ` [PATCH 15/29] nfsd41: obliterate nfsd41_copy_replay_data andros
2009-04-23 16:42                               ` [PATCH 16/29] nfsd41: obliterate nfsd4_release_respages andros
2009-04-23 16:42                                 ` [PATCH 17/29] nfsd41: remove unused nfsd4_cache_entry fields andros
2009-04-23 16:42                                   ` [PATCH 18/29] nfsd41: obliterate nfsd4_set_statp andros
2009-04-23 16:42                                     ` [PATCH 19/29] nfsd41: rename nfsd4_enc_uncached_replay andros
2009-04-23 16:42                                       ` [PATCH 20/29] nfsd41: encode replay sequence from the slot values andros
2009-04-23 16:43                                         ` [PATCH 21/29] nfsd41: remove iovlen field from nfsd4_compound_state andros
2009-04-23 16:43                                           ` [PATCH 22/29] nfsd41: obliterate nfsd41_copy_replay_data andros
2009-04-23 16:43                                             ` [PATCH 23/29] nfsd41: fix nfsd4_store_cache_entry comments andros
2009-04-23 16:43                                               ` [PATCH 24/29] nfsd41: support 16 slots per session andros
2009-04-23 16:43                                                 ` [PATCH 25/29] nfsd41: use the maximum operations per compound in nfsd4_compoundargs andros
2009-04-23 16:43                                                   ` [PATCH 26/29] nfsd41: fix nfsd4_store_cache_entry dprintk andros
2009-04-23 16:43                                                     ` [PATCH 27/29] nfsd41: add test for failed sequence operation andros
2009-04-23 16:43                                                       ` [PATCH 28/29] nfsd41: remove redundant failed sequence check andros
2009-04-23 16:43                                                         ` [PATCH 29/29] nfsd41: remove check for session andros
2009-04-23 23:39                           ` [PATCH 13/29] nfsd41: free drc cache buffers J. Bruce Fields
2009-04-24 14:11                             ` [pnfs] " William A. (Andy) Adamson
2009-04-23 23:36                 ` [PATCH 08/29] nfsd41: protect sv_drc_pages_used with spinlock J. Bruce Fields
2009-04-24 14:11                   ` [pnfs] " William A. (Andy) Adamson
2009-04-23 23:28           ` [PATCH 05/29] nfsd41: create_session cache hold client reference J. Bruce Fields
2009-04-24 13:52             ` Andy Adamson
2009-04-24 14:02               ` J. Bruce Fields
2009-04-24 14:06                 ` [pnfs] " William A. (Andy) Adamson
2009-04-23 23:25         ` [PATCH 04/29] nfsd41: replay solo and embedded create session J. Bruce Fields
2009-04-23 23:21     ` [PATCH 02/29] nfsd41: encode create_session result into cache J. Bruce Fields
2009-04-23 23:32       ` J. Bruce Fields
2009-04-24 13:56         ` Andy Adamson
2009-04-24 13:52       ` Andy Adamson
2009-04-23 22:55   ` [PATCH 01/29] nfsd41: add create session slot buffer to struc nfs4_client J. Bruce Fields
2009-04-23 23:41 ` J. Bruce Fields [this message]
2009-04-24 14:12   ` [pnfs] [PATCH 0/29] NFSv4.1 Server DRC rewrite William A. (Andy) Adamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090423234115.GO1906@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=andros@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=pnfs@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox