From: "William A. (Andy) Adamson" <androsadamson@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org, pnfs@linux-nfs.org
Subject: Re: [pnfs] [PATCH 13/29] nfsd41: free drc cache buffers
Date: Fri, 24 Apr 2009 10:11:44 -0400 [thread overview]
Message-ID: <89c397150904240711t2c951dcch15435c216f6748ca@mail.gmail.com> (raw)
In-Reply-To: <20090423233944.GN1906@fieldses.org>
On Thu, Apr 23, 2009 at 7:39 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
> On Thu, Apr 23, 2009 at 12:42:52PM -0400, andros@netapp.com wrote:
>> From: Andy Adamson <andros@netapp.com>
>
> This should probably be folded into the last patch.
>
> (For one reason: looks like applying everything up to the last patch
> would result in a kernel that leaked memory, since these things never
> got freed? The rule here is that applying patches 1...n of any patch
> series should never introduce any new problems.)
OK
>
> --b.
>
>>
>> Signed-off-by: Andy Adamson <andros@netapp.com>
>> ---
>> fs/nfsd/nfs4state.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>> index 9e79e0c..787cffe 100644
>> --- a/fs/nfsd/nfs4state.c
>> +++ b/fs/nfsd/nfs4state.c
>> @@ -590,7 +590,7 @@ free_session(struct kref *kref)
>> ses = container_of(kref, struct nfsd4_session, se_ref);
>> for (i = 0; i < ses->se_fchannel.maxreqs; i++) {
>> struct nfsd4_cache_entry *e = &ses->se_slots[i].sl_cache_entry;
>> - nfsd4_release_respages(e->ce_respages, e->ce_resused);
>> + kfree(e->ce_datav.iov_base);
>> }
>> kfree(ses);
>> }
>> --
>> 1.5.4.3
>>
> _______________________________________________
> pNFS mailing list
> pNFS@linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>
next prev parent reply other threads:[~2009-04-24 14:11 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 16:42 [PATCH 0/29] NFSv4.1 Server DRC rewrite andros
2009-04-23 16:42 ` [PATCH 01/29] nfsd41: add create session slot buffer to struc nfs4_client andros
2009-04-23 16:42 ` [PATCH 02/29] nfsd41: encode create_session result into cache andros
2009-04-23 16:42 ` [PATCH 03/29] nfsd41: create_session check replay first andros
2009-04-23 16:42 ` [PATCH 04/29] nfsd41: replay solo and embedded create session andros
2009-04-23 16:42 ` [PATCH 05/29] nfsd41: create_session cache hold client reference andros
2009-04-23 16:42 ` [PATCH 06/29] nfsd41: no nfsd4_release_respages for the clientid cache andros
2009-04-23 16:42 ` [PATCH 07/29] nfsd41: slots are freed with session andros
2009-04-23 16:42 ` [PATCH 08/29] nfsd41: protect sv_drc_pages_used with spinlock andros
2009-04-23 16:42 ` [PATCH 09/29] nfsd41: sanity check client drc maxreqs andros
2009-04-23 16:42 ` [PATCH 10/29] nfsd41: change from page to memory based drc limits andros
2009-04-23 16:42 ` [PATCH 11/29] nfsd41: set the session maximum response size cached andros
2009-04-23 16:42 ` [PATCH 12/29] nfsd41: allocate and use drc cache buffers andros
2009-04-23 16:42 ` [PATCH 13/29] nfsd41: free " andros
2009-04-23 16:42 ` [PATCH 14/29] nfsd41: obliterate nfsd4_copy_pages andros
2009-04-23 16:42 ` [PATCH 15/29] nfsd41: obliterate nfsd41_copy_replay_data andros
2009-04-23 16:42 ` [PATCH 16/29] nfsd41: obliterate nfsd4_release_respages andros
2009-04-23 16:42 ` [PATCH 17/29] nfsd41: remove unused nfsd4_cache_entry fields andros
2009-04-23 16:42 ` [PATCH 18/29] nfsd41: obliterate nfsd4_set_statp andros
2009-04-23 16:42 ` [PATCH 19/29] nfsd41: rename nfsd4_enc_uncached_replay andros
2009-04-23 16:42 ` [PATCH 20/29] nfsd41: encode replay sequence from the slot values andros
2009-04-23 16:43 ` [PATCH 21/29] nfsd41: remove iovlen field from nfsd4_compound_state andros
2009-04-23 16:43 ` [PATCH 22/29] nfsd41: obliterate nfsd41_copy_replay_data andros
2009-04-23 16:43 ` [PATCH 23/29] nfsd41: fix nfsd4_store_cache_entry comments andros
2009-04-23 16:43 ` [PATCH 24/29] nfsd41: support 16 slots per session andros
2009-04-23 16:43 ` [PATCH 25/29] nfsd41: use the maximum operations per compound in nfsd4_compoundargs andros
2009-04-23 16:43 ` [PATCH 26/29] nfsd41: fix nfsd4_store_cache_entry dprintk andros
2009-04-23 16:43 ` [PATCH 27/29] nfsd41: add test for failed sequence operation andros
2009-04-23 16:43 ` [PATCH 28/29] nfsd41: remove redundant failed sequence check andros
2009-04-23 16:43 ` [PATCH 29/29] nfsd41: remove check for session andros
2009-04-23 23:39 ` [PATCH 13/29] nfsd41: free drc cache buffers J. Bruce Fields
2009-04-24 14:11 ` William A. (Andy) Adamson [this message]
2009-04-23 23:36 ` [PATCH 08/29] nfsd41: protect sv_drc_pages_used with spinlock J. Bruce Fields
2009-04-24 14:11 ` [pnfs] " William A. (Andy) Adamson
2009-04-23 23:28 ` [PATCH 05/29] nfsd41: create_session cache hold client reference J. Bruce Fields
2009-04-24 13:52 ` Andy Adamson
2009-04-24 14:02 ` J. Bruce Fields
2009-04-24 14:06 ` [pnfs] " William A. (Andy) Adamson
2009-04-23 23:25 ` [PATCH 04/29] nfsd41: replay solo and embedded create session J. Bruce Fields
2009-04-23 23:21 ` [PATCH 02/29] nfsd41: encode create_session result into cache J. Bruce Fields
2009-04-23 23:32 ` J. Bruce Fields
2009-04-24 13:56 ` Andy Adamson
2009-04-24 13:52 ` Andy Adamson
2009-04-23 22:55 ` [PATCH 01/29] nfsd41: add create session slot buffer to struc nfs4_client J. Bruce Fields
2009-04-23 23:41 ` [PATCH 0/29] NFSv4.1 Server DRC rewrite J. Bruce Fields
2009-04-24 14:12 ` [pnfs] " William A. (Andy) Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89c397150904240711t2c951dcch15435c216f6748ca@mail.gmail.com \
--to=androsadamson@gmail.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox