public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nfs: reorder nfs4_sequence_regs to remove 8 bytes of padding on 64 bits
@ 2009-10-27 17:50 Richard Kennedy
  0 siblings, 0 replies; only message in thread
From: Richard Kennedy @ 2009-10-27 17:50 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: linux-nfs, lkml

reorder nfs4_sequence_args to remove 8 bytes of padding on 64 bit
builds. 

The size of this structure drops to 24 bytes from 32 and reduces the
text size of nfs.ko.
On my x86_64 size reports 

		text       data     bss
2.6.32-rc5 	200996	   8512	    432	 209940	  33414	nfs.ko
+patch 		200884	   8512	    432	 209828	  333a4	nfs.ko


Signed-off-by: Richard Kennedy <richard-GNCsCaawp5mSE57U5PDhIQ@public.gmane.org>

----
patch against 2.6.32-rc5
only lightly tested but it seems to work both with   
64 bit client -> 32 bit server & 32 bit client -> 64 bit server.

regards

Richard 


diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
index 62f63fb..8c88037 100644
--- a/include/linux/nfs_xdr.h
+++ b/include/linux/nfs_xdr.h
@@ -170,8 +170,8 @@ struct nfs4_sequence_args {
 struct nfs4_sequence_res {
 	struct nfs4_session	*sr_session;
 	u8			sr_slotid;	/* slot used to send request */
-	unsigned long		sr_renewal_time;
 	int			sr_status;	/* sequence operation status */
+	unsigned long		sr_renewal_time;
 };
 
 struct nfs4_get_lease_time_args {



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-10-27 17:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-27 17:50 [PATCH] nfs: reorder nfs4_sequence_regs to remove 8 bytes of padding on 64 bits Richard Kennedy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox