From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: NeilBrown <neilb@suse.de>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 5/9] sunrpc/cache: allow threads to block while waiting for cache update.
Date: Wed, 02 Dec 2009 16:50:55 -0500 [thread overview]
Message-ID: <1259790655.25518.21.camel@localhost> (raw)
In-Reply-To: <1259788985.2663.38.camel@localhost>
On Wed, 2009-12-02 at 16:23 -0500, Trond Myklebust wrote:
> Couldn't you also simplify things a good deal by just adding a
> completion to struct cache_deferred_req, and then letting
> cache_defer_req() call wait_for_completion_timeout()?
Better yet, the caller of cache_check() could decide whether or not to
also call wait_for_completion_timeout().
In addition to allowing the rpc server thread to wait upon the
authentication upcall, this could also simplify the nfsv4 server's
idmapper code, and the nfsv4 client's dns resolver code.
next prev parent reply other threads:[~2009-12-02 21:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 6:32 [PATCH 0/9] Some improvements to request deferral and related code NeilBrown
[not found] ` <20090909062539.20462.67466.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-09-09 6:32 ` [PATCH 5/9] sunrpc/cache: allow threads to block while waiting for cache update NeilBrown
[not found] ` <20090909063254.20462.99277.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-12-02 20:59 ` J. Bruce Fields
2009-12-02 21:23 ` Trond Myklebust
2009-12-02 21:50 ` Trond Myklebust [this message]
2009-09-09 6:32 ` [PATCH 3/9] sunrpc/cache: use list_del_init for the list_head entries in cache_deferred_req NeilBrown
[not found] ` <20090909063254.20462.7969.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-09-18 15:48 ` J. Bruce Fields
2009-09-09 6:32 ` [PATCH 4/9] sunrpc/cache: avoid variable over-loading in cache_defer_req NeilBrown
[not found] ` <20090909063254.20462.68582.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-09-18 21:24 ` J. Bruce Fields
2009-09-09 6:32 ` [PATCH 7/9] nfsd/idmap: drop special request deferal in favour of improved default NeilBrown
[not found] ` <20090909063254.20462.80299.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-12-02 22:18 ` J. Bruce Fields
2009-09-09 6:32 ` [PATCH 6/9] sunrpc/cache: retry cache lookups that return -ETIMEDOUT NeilBrown
[not found] ` <20090909063254.20462.41616.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-12-02 22:11 ` J. Bruce Fields
2009-12-03 16:57 ` J. Bruce Fields
2009-12-04 4:38 ` Neil Brown
[not found] ` <20091204153845.1ec83de5-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-12-05 1:17 ` J. Bruce Fields
2009-12-15 6:27 ` Neil Brown
[not found] ` <20091215172729.5e1d0190-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2010-02-01 17:11 ` J. Bruce Fields
2010-02-02 21:33 ` Neil Brown
2009-09-09 6:32 ` [PATCH 1/9] sunrpc/cache: change cache_defer_req to return -ve error, not boolean NeilBrown
[not found] ` <20090909063254.20462.57204.stgit-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-09-11 21:03 ` J. Bruce Fields
2009-09-09 6:32 ` [PATCH 2/9] sunrpc/cache: simplify cache_fresh_locked and cache_fresh_unlocked NeilBrown
2009-09-09 6:32 ` [PATCH 8/9] sunrpc/cache: change deferred-request hash table to use hlist NeilBrown
2009-09-09 6:32 ` [PATCH 9/9] sunrpc: close connection when a request is irretrievably lost NeilBrown
2009-09-11 21:07 ` [PATCH 0/9] Some improvements to request deferral and related code J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259790655.25518.21.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox