public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 1/5] SUNRPC: Fix a bug in rpcauth_prune_expired
Date: Thu, 22 Apr 2010 16:50:17 -0400	[thread overview]
Message-ID: <1271969421-7443-2-git-send-email-Trond.Myklebust@netapp.com> (raw)
In-Reply-To: <1271969421-7443-1-git-send-email-Trond.Myklebust@netapp.com>

Don't want to evict a credential if cred->cr_expire == jiffies, since that
means that it was just placed on the cred_unused list. We therefore need to
use time_in_range() rather than time_in_range_open().

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---
 net/sunrpc/auth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index f394fc1..95afe79 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -237,7 +237,7 @@ rpcauth_prune_expired(struct list_head *free, int nr_to_scan)
 	list_for_each_entry_safe(cred, next, &cred_unused, cr_lru) {
 
 		/* Enforce a 60 second garbage collection moratorium */
-		if (time_in_range_open(cred->cr_expire, expired, jiffies) &&
+		if (time_in_range(cred->cr_expire, expired, jiffies) &&
 		    test_bit(RPCAUTH_CRED_HASHED, &cred->cr_flags) != 0)
 			continue;
 
-- 
1.6.6.1


  reply	other threads:[~2010-04-22 20:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22 20:50 [PATCH 0/5] Please review bugfixes for mainline Trond Myklebust
2010-04-22 20:50 ` Trond Myklebust [this message]
2010-04-22 20:50   ` [PATCH 2/5] NFSv4: Don't attempt an atomic open if the file is a mountpoint Trond Myklebust
2010-04-22 20:50     ` [PATCH 3/5] NFS: rsize and wsize settings ignored on v4 mounts Trond Myklebust
2010-04-22 20:50       ` [PATCH 4/5] nfs: testing for null instead of ERR_PTR() Trond Myklebust
2010-04-22 20:50         ` [PATCH 5/5] NFS: Fix an unstable write data integrity race Trond Myklebust
2010-04-22 20:55           ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271969421-7443-2-git-send-email-Trond.Myklebust@netapp.com \
    --to=trond.myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox