public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 3/5] NFS: rsize and wsize settings ignored on v4 mounts
Date: Thu, 22 Apr 2010 16:50:19 -0400	[thread overview]
Message-ID: <1271969421-7443-4-git-send-email-Trond.Myklebust@netapp.com> (raw)
In-Reply-To: <1271969421-7443-3-git-send-email-Trond.Myklebust@netapp.com>

From: Chuck Lever <chuck.lever@oracle.com>

NFSv4 mounts ignore the rsize and wsize mount options, and always use
the default transfer size for both.  This seems to be because all
NFSv4 mounts are now cloned, and the cloning logic doesn't copy the
rsize and wsize settings from the parent nfs_server.

I tested Fedora's 2.6.32.11-99 and it seems to have this problem as
well, so I'm guessing that .33, .32, and perhaps older kernels have
this issue as well.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: Stable <stable@kernel.org>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---
 fs/nfs/client.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/client.c b/fs/nfs/client.c
index a8766c4..acc9c49 100644
--- a/fs/nfs/client.c
+++ b/fs/nfs/client.c
@@ -966,6 +966,8 @@ out_error:
 static void nfs_server_copy_userdata(struct nfs_server *target, struct nfs_server *source)
 {
 	target->flags = source->flags;
+	target->rsize = source->rsize;
+	target->wsize = source->wsize;
 	target->acregmin = source->acregmin;
 	target->acregmax = source->acregmax;
 	target->acdirmin = source->acdirmin;
-- 
1.6.6.1


  reply	other threads:[~2010-04-22 20:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22 20:50 [PATCH 0/5] Please review bugfixes for mainline Trond Myklebust
2010-04-22 20:50 ` [PATCH 1/5] SUNRPC: Fix a bug in rpcauth_prune_expired Trond Myklebust
2010-04-22 20:50   ` [PATCH 2/5] NFSv4: Don't attempt an atomic open if the file is a mountpoint Trond Myklebust
2010-04-22 20:50     ` Trond Myklebust [this message]
2010-04-22 20:50       ` [PATCH 4/5] nfs: testing for null instead of ERR_PTR() Trond Myklebust
2010-04-22 20:50         ` [PATCH 5/5] NFS: Fix an unstable write data integrity race Trond Myklebust
2010-04-22 20:55           ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271969421-7443-4-git-send-email-Trond.Myklebust@netapp.com \
    --to=trond.myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox