From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 5/5] NFS: Fix an unstable write data integrity race
Date: Thu, 22 Apr 2010 16:55:35 -0400 [thread overview]
Message-ID: <1271969735.5693.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1271969421-7443-6-git-send-email-Trond.Myklebust@netapp.com>
On Thu, 2010-04-22 at 16:50 -0400, Trond Myklebust wrote:
> Commit 2c61be0a9478258f77b66208a0c4b1f5f8161c3c (NFS: Ensure that the WRITE
> and COMMIT RPC calls are always uninterruptible) exposed a race on file
> close. In order to ensure correct close-to-open behaviour, we want to wait
> for all outstanding background commit operations to complete.
>
> This patch adds an inode flag that indicates if a commit operation is under
> way, and provides a mechanism to allow ->write_inode() to wait for its
> completion if this is a data integrity flush.
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> ---
BTW: There is a bugzilla report associated to this problem:
https://bugzilla.kernel.org/show_bug.cgi?id=15819
Cheers
Trond
prev parent reply other threads:[~2010-04-22 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 20:50 [PATCH 0/5] Please review bugfixes for mainline Trond Myklebust
2010-04-22 20:50 ` [PATCH 1/5] SUNRPC: Fix a bug in rpcauth_prune_expired Trond Myklebust
2010-04-22 20:50 ` [PATCH 2/5] NFSv4: Don't attempt an atomic open if the file is a mountpoint Trond Myklebust
2010-04-22 20:50 ` [PATCH 3/5] NFS: rsize and wsize settings ignored on v4 mounts Trond Myklebust
2010-04-22 20:50 ` [PATCH 4/5] nfs: testing for null instead of ERR_PTR() Trond Myklebust
2010-04-22 20:50 ` [PATCH 5/5] NFS: Fix an unstable write data integrity race Trond Myklebust
2010-04-22 20:55 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271969735.5693.1.camel@localhost.localdomain \
--to=trond.myklebust@fys.uio.no \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox