Linux NFS development
 help / color / mirror / Atom feed
* [PATCH pynfs] nfs4.1 server: DSs should have diff server owners
@ 2014-02-10 16:37 Weston Andros Adamson
  2014-02-11 17:08 ` J. Bruce Fields
  0 siblings, 1 reply; 2+ messages in thread
From: Weston Andros Adamson @ 2014-02-10 16:37 UTC (permalink / raw)
  To: bfields; +Cc: linux-nfs, Weston Andros Adamson

Use getpid() to generate the minor_id component of the server owner.

Witout this, all DSs are considered to be the same server by NFS clients
that detect server trunking, such as the upstream Linux client.

Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
---
 nfs4.1/config.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/nfs4.1/config.py b/nfs4.1/config.py
index 4f91e84..2238aee 100644
--- a/nfs4.1/config.py
+++ b/nfs4.1/config.py
@@ -3,6 +3,7 @@ from nfs4_const import *
 import nfs4_const
 import nfs4lib
 from copy import deepcopy
+import os
 
 class ConfigAction(Exception):
     pass
@@ -129,7 +130,7 @@ class ServerConfig(object):
               ]
 
     def __init__(self):
-        self.minor_id = 0
+        self.minor_id = os.getpid()
         self.major_id = "PyNFSv4.1"
         self._owner = server_owner4(self.minor_id, self.major_id)
         self.scope = "Default_Scope"
-- 
1.8.3.4 (Apple Git-47)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH pynfs] nfs4.1 server: DSs should have diff server owners
  2014-02-10 16:37 [PATCH pynfs] nfs4.1 server: DSs should have diff server owners Weston Andros Adamson
@ 2014-02-11 17:08 ` J. Bruce Fields
  0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2014-02-11 17:08 UTC (permalink / raw)
  To: Weston Andros Adamson; +Cc: linux-nfs

On Mon, Feb 10, 2014 at 11:37:02AM -0500, Weston Andros Adamson wrote:
> Use getpid() to generate the minor_id component of the server owner.
> 
> Witout this, all DSs are considered to be the same server by NFS clients
> that detect server trunking, such as the upstream Linux client.

Applied and pushed out, thanks.--b.

> 
> Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
> ---
>  nfs4.1/config.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/nfs4.1/config.py b/nfs4.1/config.py
> index 4f91e84..2238aee 100644
> --- a/nfs4.1/config.py
> +++ b/nfs4.1/config.py
> @@ -3,6 +3,7 @@ from nfs4_const import *
>  import nfs4_const
>  import nfs4lib
>  from copy import deepcopy
> +import os
>  
>  class ConfigAction(Exception):
>      pass
> @@ -129,7 +130,7 @@ class ServerConfig(object):
>                ]
>  
>      def __init__(self):
> -        self.minor_id = 0
> +        self.minor_id = os.getpid()
>          self.major_id = "PyNFSv4.1"
>          self._owner = server_owner4(self.minor_id, self.major_id)
>          self.scope = "Default_Scope"
> -- 
> 1.8.3.4 (Apple Git-47)
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-11 17:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-10 16:37 [PATCH pynfs] nfs4.1 server: DSs should have diff server owners Weston Andros Adamson
2014-02-11 17:08 ` J. Bruce Fields

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox