Linux NFS development
 help / color / mirror / Atom feed
* Re: [PATCH 3/3] NLM: Convert lockd to use kthreads
@ 2008-02-11 15:29 J. Bruce Fields
  2008-02-11 15:33 ` Jeff Layton
  0 siblings, 1 reply; 3+ messages in thread
From: J. Bruce Fields @ 2008-02-11 15:29 UTC (permalink / raw)
  To: Jeff Layton; +Cc: linux-nfs

Oops, did I forget to send this?  I don't' see it in the archives.
Apologies:

On Mon, Feb 11, 2008 at 12:22:08AM +0000, bfields wrote:
> On Thu, Feb 07, 2008 at 04:34:55PM -0500, Jeff Layton wrote:
> ...
> > diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> > index 0822646..378b393 100644
> > --- a/fs/lockd/svc.c
> > +++ b/fs/lockd/svc.c
> ...
> > @@ -174,6 +167,10 @@ lockd(struct svc_rqst *rqstp)
> >  		} else if (time_before(grace_period_expire, jiffies))
> >  			clear_grace_period();
> >  
> > +		/* nlmsvc_retry_blocked can block, so check for kthread_stop */
> > +		if (kthread_should_stop())
> > +			break;
> 
> The following svc_recv call will check kthread_should_stop() pretty
> early on, so I don't believe this is necessary?
> 
> Assuming that's correct, I've deleted these lines and applied the rest.
> 
> --b.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH 0/3] NLM: convert lockd to kthreads (try #11)
@ 2008-02-07 21:34 Jeff Layton
  2008-02-07 21:34 ` [PATCH 1/3] SUNRPC: export svc_sock_update_bufs Jeff Layton
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2008-02-07 21:34 UTC (permalink / raw)
  To: bfields; +Cc: linux-nfs

This is try #11 of the conversion of lockd to the kthread API.

The main differences from the last patchset are:

1) the addition of a patch to svc_recv to have it check
   kthread_should_stop in various places

2) the removal of the send_sig() call from lockd_down

...as Trond cleverly pointed out, if we strategically place a
kthread_should_stop call after changing the task state, then we don't
need anything else to prevent a long hang in schedule_timeout().

Comments, suggestions or ACK's appreciated...

Thanks,

Jeff Layton <jlayton@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-11 15:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-11 15:29 [PATCH 3/3] NLM: Convert lockd to use kthreads J. Bruce Fields
2008-02-11 15:33 ` Jeff Layton
  -- strict thread matches above, loose matches on Subject: below --
2008-02-07 21:34 [PATCH 0/3] NLM: convert lockd to kthreads (try #11) Jeff Layton
2008-02-07 21:34 ` [PATCH 1/3] SUNRPC: export svc_sock_update_bufs Jeff Layton
2008-02-07 21:34   ` [PATCH 2/3] SUNRPC: have svc_recv() check kthread_should_stop() Jeff Layton
2008-02-07 21:34     ` [PATCH 3/3] NLM: Convert lockd to use kthreads Jeff Layton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox