public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
* Re: POSIX ACL support for NFSV4 (using sideband protocol)
@ 2009-09-02 18:56 Steve French
  2009-09-02 20:22 ` J. Bruce Fields
  0 siblings, 1 reply; 28+ messages in thread
From: Steve French @ 2009-09-02 18:56 UTC (permalink / raw)
  To: Aneesh Kumar K.V, J. Bruce Fields
  Cc: linux-nfs, nfsv4, Trond Myklebust, ffilzlnx, jra, agruen


[-- Attachment #1.1: Type: text/plain, Size: 3280 bytes --]

"J. Bruce Fields" <bfields@fieldses.org> wrote on 09/02/2009 11:42:43 AM:
> On Wed, Sep 02, 2009 at 05:54:20PM +0530, Aneesh Kumar K.V wrote:
> > This patch series implement POSIX ACL support for NFSV4 clients
> > using sideband protocol.
>
> What motivates this?  Who exactly wants this and why?   What would be
> the advantages compared to other options, such as:

The most obvious reason to me is that security information
can be lost as the ACL which was generated by Linux utilities and
client acl tools (which get/set posix acls) are converted by the Linux nfs
v4 client
to NFSv4 ACLs on the wire and then the server converts them back to posix
to save them in ext3 (or ext4 or xfs etc.).  This double conversion can
result
in a different ACL returned on subsequent queries (e.g. getfacl) than the
one that the user just set.  At worst this is a security exposure and at
best it is confusing to the user (and we don't control the tools).
And Linux client to Linux server is worse than Linux client to some other
servers because of the extra conversion (which is counter intuitive)

>    - native v4 support in filesystems, or
Doesn't help now.  In the future would be nice to have something
similar to native cifs/ntfs/nfsv4 ACLs in btrfs - but that wouldn't help
for years - and won't help all of the other Linux
file systems.   CIFS and NTFS (and SMB2 in the future) could be
modified to return something like an NFSv4 ACL, but local file systems
aren't likely to change.  In the meantime we don't even have
a generalized system interface to set/get nfsv4/cifs/ntfs acls so
Linux ACL tools and libraries and server software
like Samba could be updated to handle something other than
posix ACLs.   I expect that jra and others of us on the Samba team
would love to see a few Linux file systems support CIFS/NFSv4/NTFS
ACLs but as he has reminded people - posix acls are Linux's native
ACL model.

>    - improved client-side acl tools that provided a user interface
>      for v4 acls closer to that for v3 acls, or
Problem is that ACLs are a "system feature" and the OS tools,
utilities and desktop GUI tools for Linux use POSIX ACLs since
Linux's "native acl interface" is the posix one.   It would make
sense to add a way to query the "preferred acl interface"
for a file system (and NFSv4 client could query the server
perhaps via a named attribute to determine the ACL type
preferred by the server fs).  It is important to use the
native ACL model of the server operating system
so that information is not lost unnecessarily in the conversion.

>    - a v4.x extension to add support to the main protocol?

Sounds fine to me to add an extension to the main protocol
but I doubt that it would be necessary - no extension was
formally added when v3 was extended for posix acls.
By analogy with cifs - we defined a new request and a new capability
bit for posix acl support.   CIFS ACL support is expected
("should" implement) but posix acl support is optional.  The
Linux client uses posix acls if the server claims support for it
and it has not been disabled on the client by mount option.

> > The ACL support can be disabled/enabled
> > using -o noacl/-o acl mount option. The feature enables to
> > view and  modify POSIX acls from NFSv4 client.

-- 
Thanks,

Steve

[-- Attachment #1.2: Type: text/html, Size: 3914 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
NFSv4 mailing list
NFSv4@linux-nfs.org
http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: POSIX ACL support for NFSV4 (using sideband protocol)
@ 2009-09-02 19:06 Steve French
  0 siblings, 0 replies; 28+ messages in thread
From: Steve French @ 2009-09-02 19:06 UTC (permalink / raw)
  To: linux-nfs

"J. Bruce Fields" <bfields@fieldses.org> wrote on 09/02/2009 11:42:43 AM:
> On Wed, Sep 02, 2009 at 05:54:20PM +0530, Aneesh Kumar K.V wrote:
> > This patch series implement POSIX ACL support for NFSV4 clients
> > using sideband protocol.
>
> What motivates this?  Who exactly wants this and why?   What would be
> the advantages compared to other options, such as:

The most obvious reason to me is that security information
can be lost as the ACL which was generated by Linux utilities and
client acl tools (which get/set posix acls) are converted by the Linux
nfs v4 client
to NFSv4 ACLs on the wire and then the server converts them back to posix
to save them in ext3 (or ext4 or xfs etc.).  This double conversion can result
in a different ACL returned on subsequent queries (e.g. getfacl) than the
one that the user just set.  At worst this is a security exposure and at
best it is confusing to the user (and we don't control the tools).
And Linux client to Linux server is worse than Linux client to some other
servers because of the extra conversion (which is counter intuitive)

>    - native v4 support in filesystems, or
Doesn't help now.  In the future would be nice to have something
similar to native cifs/ntfs/nfsv4 ACLs in btrfs - but that wouldn't help
for years - and won't help all of the other Linux
file systems.   CIFS and NTFS (and SMB2 in the future) could be
modified to return something like an NFSv4 ACL, but local file systems
aren't likely to change.  In the meantime we don't even have
a generalized system interface to set/get nfsv4/cifs/ntfs acls so
Linux ACL tools and libraries and server software
like Samba could be updated to handle something other than
posix ACLs.   I expect that jra and others of us on the Samba team
would love to see a few Linux file systems support CIFS/NFSv4/NTFS
ACLs but as he has reminded people - posix acls are Linux's native
ACL model.

>    - improved client-side acl tools that provided a user interface
>      for v4 acls closer to that for v3 acls, or
Problem is that ACLs are a "system feature" and the OS tools,
utilities and desktop GUI tools for Linux use POSIX ACLs since
Linux's "native acl interface" is the posix one.   It would make
sense to add a way to query the "preferred acl interface"
for a file system (and NFSv4 client could query the server
perhaps via a named attribute to determine the ACL type
preferred by the server fs).  It is important to use the
native ACL model of the server operating system
so that information is not lost unnecessarily in the conversion.

>    - a v4.x extension to add support to the main protocol?

Sounds fine to me to add an extension to the main protocol
but I doubt that it would be necessary - no extension was
formally added when v3 was extended for posix acls.
By analogy with cifs - we defined a new request and a new capability
bit for posix acl support.   CIFS ACL support is expected
("should" implement) but posix acl support is optional.  The
Linux client uses posix acls if the server claims support for it
and it has not been disabled on the client by mount option.

> > The ACL support can be disabled/enabled
> > using -o noacl/-o acl mount option. The feature enables to
> > view and  modify POSIX acls from NFSv4 client.


--
Thanks,

Steve

^ permalink raw reply	[flat|nested] 28+ messages in thread
* POSIX ACL support for NFSV4 (using sideband protocol)
@ 2009-09-02 12:24 Aneesh Kumar K.V
  2009-09-02 16:42 ` J. Bruce Fields
  0 siblings, 1 reply; 28+ messages in thread
From: Aneesh Kumar K.V @ 2009-09-02 12:24 UTC (permalink / raw)
  To: trond.myklebust, bfields, nfsv4, ffilzlnx, agruen, aneesh.kumar,
	sfrench
  Cc: linux-nfs

This patch series implement POSIX ACL support for NFSV4 clients
using sideband protocol. The ACL support can be disabled/enabled
using -o noacl/-o acl mount option. The feature enables to
view and  modify POSIX acls from NFSv4 client.

-aneesh


^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2009-10-05 17:19 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-02 18:56 POSIX ACL support for NFSV4 (using sideband protocol) Steve French
2009-09-02 20:22 ` J. Bruce Fields
2009-09-02 20:53   ` Steve French
2009-09-03  6:20     ` Ondrej Valousek
2009-09-03  7:46       ` Muntz, Daniel
2009-09-03 10:41         ` Aneesh Kumar K.V
2009-09-03 13:36         ` Steve French
2009-09-03 13:54           ` J. Bruce Fields
2009-09-03 13:57             ` Steve French
2009-09-03 15:01         ` David P. Quigley
2009-09-03 13:54       ` Steve French
2009-09-03 13:55         ` J. Bruce Fields
2009-09-03 15:35           ` Steve French
     [not found]             ` <524f69650909030835s41e78436p4b67594cf91de639-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-09-03 16:08               ` J. Bruce Fields
2009-09-03 14:09         ` Trond Myklebust
2009-09-03 18:55           ` Andreas Gruenbacher
2009-09-03 14:16     ` J. Bruce Fields
2009-09-03 15:14       ` Steve French
2009-10-05 16:31   ` Andreas Gruenbacher
2009-10-05 16:44     ` Steve French
2009-10-05 17:09       ` Andreas Gruenbacher
2009-10-05 17:19         ` Steve French
  -- strict thread matches above, loose matches on Subject: below --
2009-09-02 19:06 Steve French
2009-09-02 12:24 Aneesh Kumar K.V
2009-09-02 16:42 ` J. Bruce Fields
2009-09-02 17:49   ` Aneesh Kumar K.V
2009-09-02 18:27     ` J. Bruce Fields
2009-09-03 19:09   ` Andreas Gruenbacher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox