From: Ben Myers <bpm@sgi.com>
To: SteveD@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/3] nfs-utils: multithreaded mountd fixes
Date: Thu, 28 Jan 2010 15:26:24 -0600 [thread overview]
Message-ID: <20100128211454.29681.24752.stgit@case.americas.sgi.com> (raw)
Hey Steve,
The following fixes a problem with mountd where you get backed up behind the
rmtab lock. It may have happened that an xflock timed out and stat failed so
the filedescriptor was leaked in mountlist_list and the lock never released.
Skipping the fdatasync has also helped performance-wise.
Tested very lightly on TOT and more heavily on 1.0.7 where this bug was
discovered.
Thanks,
Ben
---
Ben Myers (3):
nfs-utils: remove xflock timeout
nfs-utils: dont leak fd in mountlist_list
nfs-utils: don't fdatasync the rmtab
support/nfs/cacheio.c | 5 ++---
support/nfs/rmtab.c | 23 ++++++++++++++++++-----
support/nfs/xio.c | 18 +-----------------
utils/mountd/rmtab.c | 5 ++++-
4 files changed, 25 insertions(+), 26 deletions(-)
--
next reply other threads:[~2010-01-28 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 21:26 Ben Myers [this message]
[not found] ` <20100128211454.29681.24752.stgit-PhfrMOq4MEUPybYDWDrblq0bRtRcJeJQ@public.gmane.org>
2010-01-28 21:26 ` [PATCH 1/3] nfs-utils: remove xflock timeout Ben Myers
2010-01-28 21:26 ` [PATCH 2/3] nfs-utils: dont leak fd in mountlist_list Ben Myers
2010-01-28 21:26 ` [PATCH 3/3] nfs-utils: don't fdatasync the rmtab Ben Myers
2010-02-12 19:03 ` [PATCH 0/3] nfs-utils: multithreaded mountd fixes Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128211454.29681.24752.stgit@case.americas.sgi.com \
--to=bpm@sgi.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox