From: Ben Myers <bpm@sgi.com>
To: SteveD@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 2/3] nfs-utils: dont leak fd in mountlist_list
Date: Thu, 28 Jan 2010 15:26:34 -0600 [thread overview]
Message-ID: <20100128212634.29681.43239.stgit@case.americas.sgi.com> (raw)
In-Reply-To: <20100128211454.29681.24752.stgit-PhfrMOq4MEUPybYDWDrblq0bRtRcJeJQ@public.gmane.org>
Don't leak this file descriptor if stat should fail.
---
utils/mountd/rmtab.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/utils/mountd/rmtab.c b/utils/mountd/rmtab.c
index b028529..19b22ee 100644
--- a/utils/mountd/rmtab.c
+++ b/utils/mountd/rmtab.c
@@ -24,6 +24,7 @@
#include "ha-callout.h"
#include <limits.h> /* PATH_MAX */
+#include <errno.h>
extern int reverse_resolve;
@@ -187,7 +188,9 @@ mountlist_list(void)
if ((lockid = xflock(_PATH_RMTABLCK, "r")) < 0)
return NULL;
if (stat(_PATH_RMTAB, &stb) < 0) {
- xlog(L_ERROR, "can't stat %s", _PATH_RMTAB);
+ xlog(L_ERROR, "can't stat %s: %s",
+ _PATH_RMTAB, strerror(errno));
+ xfunlock(lockid);
return NULL;
}
if (stb.st_mtime != last_mtime) {
next prev parent reply other threads:[~2010-01-28 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 21:26 [PATCH 0/3] nfs-utils: multithreaded mountd fixes Ben Myers
[not found] ` <20100128211454.29681.24752.stgit-PhfrMOq4MEUPybYDWDrblq0bRtRcJeJQ@public.gmane.org>
2010-01-28 21:26 ` [PATCH 1/3] nfs-utils: remove xflock timeout Ben Myers
2010-01-28 21:26 ` Ben Myers [this message]
2010-01-28 21:26 ` [PATCH 3/3] nfs-utils: don't fdatasync the rmtab Ben Myers
2010-02-12 19:03 ` [PATCH 0/3] nfs-utils: multithreaded mountd fixes Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128212634.29681.43239.stgit@case.americas.sgi.com \
--to=bpm@sgi.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox