From: Ben Myers <bpm@sgi.com>
To: SteveD@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 1/3] nfs-utils: remove xflock timeout
Date: Thu, 28 Jan 2010 15:26:29 -0600 [thread overview]
Message-ID: <20100128212629.29681.53047.stgit@case.americas.sgi.com> (raw)
In-Reply-To: <20100128211454.29681.24752.stgit-PhfrMOq4MEUPybYDWDrblq0bRtRcJeJQ@public.gmane.org>
Remove this 10 second timeout which can cause unexpected behavior and
corruption in the rmtab when hit.
---
support/nfs/xio.c | 18 +-----------------
1 files changed, 1 insertions(+), 17 deletions(-)
diff --git a/support/nfs/xio.c b/support/nfs/xio.c
index 5e2e1e9..e3d27d2 100644
--- a/support/nfs/xio.c
+++ b/support/nfs/xio.c
@@ -44,16 +44,9 @@ xfclose(XFILE *xfp)
xfree(xfp);
}
-static void
-doalarm(int sig)
-{
- return;
-}
-
int
xflock(char *fname, char *type)
{
- struct sigaction sa, oldsa;
int readonly = !strcmp(type, "r");
struct flock fl = { readonly? F_RDLCK : F_WRLCK, SEEK_SET, 0, 0, 0 };
int fd;
@@ -68,21 +61,12 @@ xflock(char *fname, char *type)
return -1;
}
- sa.sa_handler = doalarm;
- sa.sa_flags = 0;
- sigemptyset(&sa.sa_mask);
- sigaction(SIGALRM, &sa, &oldsa);
- alarm(10);
if (fcntl(fd, F_SETLKW, &fl) < 0) {
- alarm(0);
xlog(L_WARNING, "failed to lock %s: errno %d (%s)",
fname, errno, strerror(errno));
close(fd);
- fd = 0;
- } else {
- alarm(0);
+ fd = -1;
}
- sigaction(SIGALRM, &oldsa, NULL);
return fd;
}
next prev parent reply other threads:[~2010-01-28 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 21:26 [PATCH 0/3] nfs-utils: multithreaded mountd fixes Ben Myers
[not found] ` <20100128211454.29681.24752.stgit-PhfrMOq4MEUPybYDWDrblq0bRtRcJeJQ@public.gmane.org>
2010-01-28 21:26 ` Ben Myers [this message]
2010-01-28 21:26 ` [PATCH 2/3] nfs-utils: dont leak fd in mountlist_list Ben Myers
2010-01-28 21:26 ` [PATCH 3/3] nfs-utils: don't fdatasync the rmtab Ben Myers
2010-02-12 19:03 ` [PATCH 0/3] nfs-utils: multithreaded mountd fixes Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128212629.29681.53047.stgit@case.americas.sgi.com \
--to=bpm@sgi.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox