* NFS writes broken in net-next-2.6
@ 2010-09-08 20:01 Ben Hutchings
2010-09-08 20:05 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2010-09-08 20:01 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-nfs
In net-next-2.6, close() of a file after writing tends to return 1.
This causes e.g. gcc to abort.
This appears to have been fixed in 2.6.36-rc2:
commit 0702099bd86c33c2dcdbd3963433a61f3f503901
Author: J. R. Okajima <hooanon05@yahoo.co.jp>
Date: Wed Aug 11 13:10:16 2010 -0400
NFS: fix the return value of nfs_file_fsync()
Please consider merging this fix in some way.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: NFS writes broken in net-next-2.6
2010-09-08 20:01 NFS writes broken in net-next-2.6 Ben Hutchings
@ 2010-09-08 20:05 ` David Miller
2010-09-08 20:14 ` Ben Hutchings
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2010-09-08 20:05 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-nfs
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 08 Sep 2010 21:01:08 +0100
> In net-next-2.6, close() of a file after writing tends to return 1.
> This causes e.g. gcc to abort.
>
> This appears to have been fixed in 2.6.36-rc2:
>
> commit 0702099bd86c33c2dcdbd3963433a61f3f503901
> Author: J. R. Okajima <hooanon05@yahoo.co.jp>
> Date: Wed Aug 11 13:10:16 2010 -0400
>
> NFS: fix the return value of nfs_file_fsync()
>
> Please consider merging this fix in some way.
Ben, and please I've told you this before, if you need a specific
upstream fix do your testing on a branch that pulls in Linus's tree
or, alternatively, apply the fix you need by hand using "git stash" or
similar.
All of this is in your own hands. You do not need me to merge in
every single upstream fix you might need.
I have this issue myself when testing both the sparc tree and the
various net trees all the time.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: NFS writes broken in net-next-2.6
2010-09-08 20:05 ` David Miller
@ 2010-09-08 20:14 ` Ben Hutchings
0 siblings, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2010-09-08 20:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-nfs
On Wed, 2010-09-08 at 13:05 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Wed, 08 Sep 2010 21:01:08 +0100
>
> > In net-next-2.6, close() of a file after writing tends to return 1.
> > This causes e.g. gcc to abort.
> >
> > This appears to have been fixed in 2.6.36-rc2:
> >
> > commit 0702099bd86c33c2dcdbd3963433a61f3f503901
> > Author: J. R. Okajima <hooanon05@yahoo.co.jp>
> > Date: Wed Aug 11 13:10:16 2010 -0400
> >
> > NFS: fix the return value of nfs_file_fsync()
> >
> > Please consider merging this fix in some way.
>
> Ben, and please I've told you this before,
I don't think so.
> if you need a specific
> upstream fix do your testing on a branch that pulls in Linus's tree
> or, alternatively, apply the fix you need by hand using "git stash" or
> similar.
[...]
Sure, that's what I'm doing. But this is likely to hit more developers
than just me.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-08 20:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-08 20:01 NFS writes broken in net-next-2.6 Ben Hutchings
2010-09-08 20:05 ` David Miller
2010-09-08 20:14 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox