* [PATCH] fix ptr_ret.cocci warnings
2015-06-24 15:00 [nfs:testing 41/50] fs/nfs/nfs42proc.c:191:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot
@ 2015-06-24 15:00 ` kbuild test robot
0 siblings, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2015-06-24 15:00 UTC (permalink / raw)
To: Trond Myklebust; +Cc: kbuild-all, Jeff Layton, Peng Tao, linux-nfs
fs/nfs/nfs42proc.c:191:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
nfs42proc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/fs/nfs/nfs42proc.c
+++ b/fs/nfs/nfs42proc.c
@@ -188,7 +188,5 @@ int nfs42_proc_layoutstats_generic(struc
nfs4_init_sequence(&data->args.seq_args, &data->res.seq_res, 0);
task = rpc_run_task(&task_setup);
- if (IS_ERR(task))
- return PTR_ERR(task);
- return 0;
+ return PTR_ERR_OR_ZERO(task);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [nfs:testing 41/50] fs/nfs/nfs42proc.c:191:1-3: WARNING: PTR_ERR_OR_ZERO can be used
@ 2015-06-24 15:00 kbuild test robot
2015-06-24 15:00 ` [PATCH] fix ptr_ret.cocci warnings kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-06-24 15:00 UTC (permalink / raw)
To: Trond Myklebust; +Cc: kbuild-all, Jeff Layton, Peng Tao, linux-nfs
tree: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git testing
head: f890ffcf683f2bf8d90f2a4918041f8988ccfbbe
commit: be3a5d233922d73f27002ce2767f6ec03c3f473d [41/50] NFSv.2/pnfs Add a LAYOUTSTATS rpc function
coccinelle warnings: (new ones prefixed by >>)
>> fs/nfs/nfs42proc.c:191:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] fix ptr_ret.cocci warnings
2018-10-24 19:58 [PATCH v2 10/13] NFS inter ssc open Olga Kornievskaia
@ 2018-10-25 1:31 ` kbuild test robot
0 siblings, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2018-10-25 1:31 UTC (permalink / raw)
To: Olga Kornievskaia
Cc: kbuild-all, trond.myklebust, anna.schumaker, viro, smfrench,
miklos, linux-nfs, linux-fsdevel, linux-cifs, linux-unionfs,
linux-man
From: kbuild test robot <fengguang.wu@intel.com>
fs/nfs/nfs4file.c:345:12-18: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: 53b276379386 ("NFS inter ssc open")
CC: Olga Kornievskaia <kolga@netapp.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/client-side-support-for-inter-SSC-copy/20181025-043859
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
nfs4file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/nfs/nfs4file.c
+++ b/fs/nfs/nfs4file.c
@@ -342,7 +342,7 @@ nfs42_ssc_open(struct vfsmount *ss_mnt,
res = filep;
out:
dprintk("<-- %s error %ld filep %p r_ino %p\n",
- __func__, IS_ERR(res) ? PTR_ERR(res) : 0, res, r_ino);
+ __func__, PTR_ERR_OR_ZERO(res), res, r_ino);
return res;
out_stateowner:
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-25 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-24 15:00 [nfs:testing 41/50] fs/nfs/nfs42proc.c:191:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot
2015-06-24 15:00 ` [PATCH] fix ptr_ret.cocci warnings kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2018-10-24 19:58 [PATCH v2 10/13] NFS inter ssc open Olga Kornievskaia
2018-10-25 1:31 ` [PATCH] fix ptr_ret.cocci warnings kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox