From: "J. Bruce Fields" <bfields@fieldses.org>
To: Alex Lyakas <alex@zadara.com>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
Shyam Kaushik <shyam@zadara.com>
Subject: Re: [RFC-PATCH] nfsd: when unhashing openowners, increment openowner's refcount
Date: Mon, 26 Aug 2019 09:39:51 -0400 [thread overview]
Message-ID: <20190826133951.GC22759@fieldses.org> (raw)
In-Reply-To: <CAOcd+r0bXefi79dnwrwsDN1OecScfTjc8DYS5_9A8D5XKrh7QQ@mail.gmail.com>
On Sun, Aug 25, 2019 at 01:12:34PM +0300, Alex Lyakas wrote:
> You are listed as maintainers of nfsd. Can you please take a look at
> the below patch?
Thanks!
I take it this was found by some kind of code analysis or fuzzing, not
use in production?
Asking because I've been considering just deprecating it, so:
> > After we fixed this, we confirmed that the openowner is not freed
> > prematurely. It is freed by release_openowner() final call
> > to nfs4_put_stateowner().
> >
> > However, we still get (other) random crashes and memory corruptions
> > when nfsd_inject_forget_client_openowners() and
> > nfsd_inject_forget_openowners().
> > According to our analysis, we don't see any other refcount issues.
> > Can anybody from the community review these flows for other potentials issues?
I'm wondering how much effort we want to put into tracking all that
down.
--b.
next prev parent reply other threads:[~2019-08-26 13:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 16:49 [RFC-PATCH] nfsd: when unhashing openowners, increment openowner's refcount Alex Lyakas
2019-08-25 10:12 ` Alex Lyakas
2019-08-26 13:39 ` J. Bruce Fields [this message]
2019-08-26 14:38 ` J. Bruce Fields
2019-08-27 9:05 ` Alex Lyakas
2019-08-27 20:51 ` J. Bruce Fields
2019-08-28 15:20 ` Alex Lyakas
2019-08-28 16:54 ` J. Bruce Fields
2019-08-29 18:12 ` Alex Lyakas
2019-08-30 19:08 ` J. Bruce Fields
2019-09-03 13:47 ` Alex Lyakas
2019-08-30 19:54 ` J. Bruce Fields
2019-09-03 13:48 ` Alex Lyakas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826133951.GC22759@fieldses.org \
--to=bfields@fieldses.org \
--cc=alex@zadara.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=shyam@zadara.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox