From: "J. Bruce Fields" <bfields@fieldses.org>
To: Alex Lyakas <alex@zadara.com>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
Shyam Kaushik <shyam@zadara.com>
Subject: Re: [RFC-PATCH] nfsd: when unhashing openowners, increment openowner's refcount
Date: Tue, 27 Aug 2019 16:51:58 -0400 [thread overview]
Message-ID: <20190827205158.GB13198@fieldses.org> (raw)
In-Reply-To: <CAOcd+r059fh7J8T=6MdjPSCP39K5fpOZTsXZDUKq5TrPv_RcVQ@mail.gmail.com>
On Tue, Aug 27, 2019 at 12:05:28PM +0300, Alex Lyakas wrote:
> Is the described issue familiar to you?
Yep, got it, but I haven't seen anyone try to solve it using the fault
injection code, that's interesting!
There's also fs/nfsd/unlock_filesystem. It only unlocks NLM (NFSv3)
locks. But it'd probably be reasonable to teach it to get NFSv4 state
too (locks, opens, delegations, and layouts).
But my feeling's always been that the cleanest way to do it is to create
two containers with separate net namespaces and run nfsd in both of
them. You can start and stop the servers in the different containers
independently.
> It is very easily reproducible. What is the way to solve it? To our
> understanding, if we un-export a FS from nfsd, we should be able to
> unmount it.
Unexporting has never removed locks or opens or other state, for what
it's worth.
--b.
next prev parent reply other threads:[~2019-08-27 20:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 16:49 [RFC-PATCH] nfsd: when unhashing openowners, increment openowner's refcount Alex Lyakas
2019-08-25 10:12 ` Alex Lyakas
2019-08-26 13:39 ` J. Bruce Fields
2019-08-26 14:38 ` J. Bruce Fields
2019-08-27 9:05 ` Alex Lyakas
2019-08-27 20:51 ` J. Bruce Fields [this message]
2019-08-28 15:20 ` Alex Lyakas
2019-08-28 16:54 ` J. Bruce Fields
2019-08-29 18:12 ` Alex Lyakas
2019-08-30 19:08 ` J. Bruce Fields
2019-09-03 13:47 ` Alex Lyakas
2019-08-30 19:54 ` J. Bruce Fields
2019-09-03 13:48 ` Alex Lyakas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827205158.GB13198@fieldses.org \
--to=bfields@fieldses.org \
--cc=alex@zadara.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=shyam@zadara.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox