From: "J. Bruce Fields" <bfields@fieldses.org>
To: Alex Lyakas <alex@zadara.com>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
Shyam Kaushik <shyam@zadara.com>
Subject: Re: [RFC-PATCH] nfsd: when unhashing openowners, increment openowner's refcount
Date: Fri, 30 Aug 2019 15:54:43 -0400 [thread overview]
Message-ID: <20190830195443.GC5053@fieldses.org> (raw)
In-Reply-To: <CAOcd+r3e52q_ds3zjya98whYarqoXf5C2umNEX-AGp4-R6=Cuw@mail.gmail.com>
On Thu, Aug 29, 2019 at 09:12:49PM +0300, Alex Lyakas wrote:
> Would moving this code into the "unlock_filesystem" infrastructure be
> acceptable? Since the "share_id" approach is very custom for our
> usage, what criteria would you suggest for selecting the openowners to
> be "forgotten"?
Have you looked at what unlock_filesystem()? It's just translating the
given path to a superblock, then matching that against inodes in
nlmsvc_match_sb().
It's a little more complicated for nfs4_files since they don't have a
pointer to the inode. (Maybe it should.) You can see how I get around
this in e.g. fs/nfsd/nfs4state.c:nfs4_show_lock().
A superblock isn't the same thing as an export, thanks to bind mounts
and subdirectory exports. But if the goal is to be able to unmount,
then a superblock is probably what you want.
--b.
next prev parent reply other threads:[~2019-08-30 19:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 16:49 [RFC-PATCH] nfsd: when unhashing openowners, increment openowner's refcount Alex Lyakas
2019-08-25 10:12 ` Alex Lyakas
2019-08-26 13:39 ` J. Bruce Fields
2019-08-26 14:38 ` J. Bruce Fields
2019-08-27 9:05 ` Alex Lyakas
2019-08-27 20:51 ` J. Bruce Fields
2019-08-28 15:20 ` Alex Lyakas
2019-08-28 16:54 ` J. Bruce Fields
2019-08-29 18:12 ` Alex Lyakas
2019-08-30 19:08 ` J. Bruce Fields
2019-09-03 13:47 ` Alex Lyakas
2019-08-30 19:54 ` J. Bruce Fields [this message]
2019-09-03 13:48 ` Alex Lyakas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830195443.GC5053@fieldses.org \
--to=bfields@fieldses.org \
--cc=alex@zadara.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=shyam@zadara.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox