From: schumaker.anna@gmail.com
To: steved@redhat.com, linux-nfs@vger.kernel.org
Cc: Anna.Schumaker@Netapp.com
Subject: [PATCH v5 3/9] rpcctl: Add a command for printing individual xprts
Date: Thu, 28 Oct 2021 14:35:13 -0400 [thread overview]
Message-ID: <20211028183519.160772-4-Anna.Schumaker@Netapp.com> (raw)
In-Reply-To: <20211028183519.160772-1-Anna.Schumaker@Netapp.com>
From: Anna Schumaker <Anna.Schumaker@Netapp.com>
This shows more detailed information than what is presented with xprt
switches. I take the chance to add a main-export indicator to the
small_str() used when printing out xprt-switches.
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
v5: Clean up how the Xprt __str__() function works
---
tools/rpcctl/rpcctl.py | 2 ++
tools/rpcctl/xprt.py | 43 +++++++++++++++++++++++++++++++++++++++++-
2 files changed, 44 insertions(+), 1 deletion(-)
diff --git a/tools/rpcctl/rpcctl.py b/tools/rpcctl/rpcctl.py
index 90efcbed7ac8..dfad6ac08fa0 100755
--- a/tools/rpcctl/rpcctl.py
+++ b/tools/rpcctl/rpcctl.py
@@ -11,8 +11,10 @@ parser.set_defaults(func=show_small_help)
import switch
+import xprt
subparser = parser.add_subparsers(title="commands")
switch.add_command(subparser)
+xprt.add_command(subparser)
args = parser.parse_args()
diff --git a/tools/rpcctl/xprt.py b/tools/rpcctl/xprt.py
index 62859a23ea4d..f8c8110eeed6 100644
--- a/tools/rpcctl/xprt.py
+++ b/tools/rpcctl/xprt.py
@@ -5,10 +5,51 @@ class Xprt:
self.path = path
self.id = int(path.stem.split("-")[1])
self.type = path.stem.split("-")[2]
+ self.info = sysfs.read_info_file(path / "xprt_info")
self.dstaddr = sysfs.read_addr_file(path / "dstaddr")
+ self.srcaddr = sysfs.read_addr_file(path / "srcaddr")
+
+ with open(path / "xprt_state") as f:
+ self.state = ','.join(f.readline().split()[1:])
def __lt__(self, rhs):
return self.id < rhs.id
+ def _xprt(self):
+ main = ", main" if self.info.get("main_xprt") else ""
+ return f"xprt {self.id}: {self.type}, {self.dstaddr}, " \
+ f"port {self.info['dst_port']}, state <{self.state}>{main}"
+
+ def _src_reqs(self):
+ return f" Source: {self.srcaddr}, port {self.info['src_port']}, " \
+ f"Requests: {self.info['num_reqs']}"
+
+ def _cong_slots(self):
+ return f" Congestion: cur {self.info['cur_cong']}, win {self.info['cong_win']}, " \
+ f"Slots: min {self.info['min_num_slots']}, max {self.info['max_num_slots']}"
+
+ def _queues(self):
+ return f" Queues: binding {self.info['binding_q_len']}, " \
+ f"sending {self.info['sending_q_len']}, pending {self.info['pending_q_len']}, " \
+ f"backlog {self.info['backlog_q_len']}, tasks {self.info['tasks_queuelen']}"
+
+ def __str__(self):
+ return "\n".join([self._xprt(), self._src_reqs(),
+ self._cong_slots(), self._queues() ])
+
def small_str(self):
- return f"xprt {self.id}: {self.type}, {self.dstaddr}"
+ main = " [main]" if self.info.get("main_xprt") else ""
+ return f"xprt {self.id}: {self.type}, {self.dstaddr}{main}"
+
+
+def list_xprts(args):
+ xprts = [ Xprt(f) for f in (sysfs.SUNRPC / "xprt-switches").glob("**/xprt-*") ]
+ xprts.sort()
+ for xprt in xprts:
+ if args.id == None or xprt.id == args.id[0]:
+ print(xprt)
+
+def add_command(subparser):
+ parser = subparser.add_parser("xprt", help="Commands for individual xprts")
+ parser.add_argument("--id", metavar="ID", nargs=1, type=int, help="Id of a specific xprt to show")
+ parser.set_defaults(func=list_xprts)
--
2.33.1
next prev parent reply other threads:[~2021-10-28 18:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 18:35 [PATCH v5 0/9] Add a tool for using the new sysfs files schumaker.anna
2021-10-28 18:35 ` [PATCH v5 1/9] rpcctl: Add a rpcctl.py tool schumaker.anna
2021-10-28 18:35 ` [PATCH v5 2/9] rpcctl: Add a command for printing xprt switch information schumaker.anna
2021-10-28 18:35 ` schumaker.anna [this message]
2021-10-28 18:35 ` [PATCH v5 4/9] rpcctl: Add a command for printing rpc client information schumaker.anna
2021-10-28 18:35 ` [PATCH v5 5/9] rpcctl: Add a command for changing xprt dstaddr schumaker.anna
2021-10-28 18:35 ` [PATCH v5 6/9] rpcctl: Add a command for changing xprt switch dstaddrs schumaker.anna
2021-10-28 18:35 ` [PATCH v5 7/9] rpcctl: Add a command for changing xprt state schumaker.anna
2021-10-28 18:35 ` [PATCH v5 8/9] rpcctl: Add a man page schumaker.anna
2021-10-28 18:35 ` [PATCH v5 9/9] rpcctl: Add installation to the Makefile schumaker.anna
2021-11-08 17:15 ` Steve Dickson
2021-11-08 17:19 ` Steve Dickson
2021-11-08 18:15 ` Anna Schumaker
2021-11-01 14:40 ` [PATCH v5 0/9] Add a tool for using the new sysfs files Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028183519.160772-4-Anna.Schumaker@Netapp.com \
--to=schumaker.anna@gmail.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox