public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: schumaker.anna@gmail.com
To: steved@redhat.com, linux-nfs@vger.kernel.org
Cc: Anna.Schumaker@Netapp.com
Subject: [PATCH v5 6/9] rpcctl: Add a command for changing xprt switch dstaddrs
Date: Thu, 28 Oct 2021 14:35:16 -0400	[thread overview]
Message-ID: <20211028183519.160772-7-Anna.Schumaker@Netapp.com> (raw)
In-Reply-To: <20211028183519.160772-1-Anna.Schumaker@Netapp.com>

From: Anna Schumaker <Anna.Schumaker@Netapp.com>

This is basically the same as for xprts, but it iterates through all
xprts attached to the switch to apply the new address.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
 tools/rpcctl/switch.py | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/tools/rpcctl/switch.py b/tools/rpcctl/switch.py
index 497ee8b1923c..b1b287bb6578 100644
--- a/tools/rpcctl/switch.py
+++ b/tools/rpcctl/switch.py
@@ -30,7 +30,22 @@ def list_xprt_switches(args):
         if args.id == None or xs.id == args.id[0]:
             print(xs)
 
+def set_xprt_switch_property(args):
+    switch = XprtSwitch(sysfs.SUNRPC / "xprt-switches" / f"switch-{args.id[0]}")
+    try:
+        for xprt in switch.xprts:
+            xprt.set_dstaddr(args.dstaddr[0])
+        print(switch)
+    except Exception as e:
+        print(e)
+
 def add_command(subparser):
     parser = subparser.add_parser("switch", help="Commands for xprt switches")
     parser.add_argument("--id", metavar="ID", nargs=1, type=int, help="Id of a specific xprt-switch to show")
     parser.set_defaults(func=list_xprt_switches)
+
+    subparser = parser.add_subparsers()
+    parser = subparser.add_parser("set", help="Set an xprt switch property")
+    parser.add_argument("--id", metavar="ID", nargs=1, type=int, required=True, help="Id of an xprt-switch to modify")
+    parser.add_argument("--dstaddr", metavar="dstaddr", nargs=1, type=str, help="New dstaddr to set")
+    parser.set_defaults(func=set_xprt_switch_property)
-- 
2.33.1


  parent reply	other threads:[~2021-10-28 18:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 18:35 [PATCH v5 0/9] Add a tool for using the new sysfs files schumaker.anna
2021-10-28 18:35 ` [PATCH v5 1/9] rpcctl: Add a rpcctl.py tool schumaker.anna
2021-10-28 18:35 ` [PATCH v5 2/9] rpcctl: Add a command for printing xprt switch information schumaker.anna
2021-10-28 18:35 ` [PATCH v5 3/9] rpcctl: Add a command for printing individual xprts schumaker.anna
2021-10-28 18:35 ` [PATCH v5 4/9] rpcctl: Add a command for printing rpc client information schumaker.anna
2021-10-28 18:35 ` [PATCH v5 5/9] rpcctl: Add a command for changing xprt dstaddr schumaker.anna
2021-10-28 18:35 ` schumaker.anna [this message]
2021-10-28 18:35 ` [PATCH v5 7/9] rpcctl: Add a command for changing xprt state schumaker.anna
2021-10-28 18:35 ` [PATCH v5 8/9] rpcctl: Add a man page schumaker.anna
2021-10-28 18:35 ` [PATCH v5 9/9] rpcctl: Add installation to the Makefile schumaker.anna
2021-11-08 17:15   ` Steve Dickson
2021-11-08 17:19     ` Steve Dickson
2021-11-08 18:15       ` Anna Schumaker
2021-11-01 14:40 ` [PATCH v5 0/9] Add a tool for using the new sysfs files Chuck Lever III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211028183519.160772-7-Anna.Schumaker@Netapp.com \
    --to=schumaker.anna@gmail.com \
    --cc=Anna.Schumaker@Netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox