From: schumaker.anna@gmail.com
To: steved@redhat.com, linux-nfs@vger.kernel.org
Cc: Anna.Schumaker@Netapp.com
Subject: [PATCH v5 5/9] rpcctl: Add a command for changing xprt dstaddr
Date: Thu, 28 Oct 2021 14:35:15 -0400 [thread overview]
Message-ID: <20211028183519.160772-6-Anna.Schumaker@Netapp.com> (raw)
In-Reply-To: <20211028183519.160772-1-Anna.Schumaker@Netapp.com>
From: Anna Schumaker <Anna.Schumaker@Netapp.com>
Using the socket module for dns resolution
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
tools/rpcctl/sysfs.py | 5 +++++
tools/rpcctl/xprt.py | 26 ++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
diff --git a/tools/rpcctl/sysfs.py b/tools/rpcctl/sysfs.py
index c05d2d591175..27726c56bb80 100644
--- a/tools/rpcctl/sysfs.py
+++ b/tools/rpcctl/sysfs.py
@@ -27,6 +27,11 @@ def read_addr_file(path):
except:
return "(enoent)"
+def write_addr_file(path, newaddr):
+ with open(path, 'w') as f:
+ f.write(newaddr)
+ return read_addr_file(path)
+
def read_info_file(path):
res = collections.defaultdict(int)
try:
diff --git a/tools/rpcctl/xprt.py b/tools/rpcctl/xprt.py
index f8c8110eeed6..1201140ce5af 100644
--- a/tools/rpcctl/xprt.py
+++ b/tools/rpcctl/xprt.py
@@ -1,3 +1,4 @@
+import socket
import sysfs
class Xprt:
@@ -41,6 +42,10 @@ class Xprt:
main = " [main]" if self.info.get("main_xprt") else ""
return f"xprt {self.id}: {self.type}, {self.dstaddr}{main}"
+ def set_dstaddr(self, newaddr):
+ resolved = socket.gethostbyname(newaddr)
+ self.dstaddr = sysfs.write_addr_file(self.path / "dstaddr", resolved)
+
def list_xprts(args):
xprts = [ Xprt(f) for f in (sysfs.SUNRPC / "xprt-switches").glob("**/xprt-*") ]
@@ -49,7 +54,28 @@ def list_xprts(args):
if args.id == None or xprt.id == args.id[0]:
print(xprt)
+def get_xprt(id):
+ xprts = [ Xprt(f) for f in (sysfs.SUNRPC / "xprt-switches").glob("**/xprt-*") ]
+ for xprt in xprts:
+ if xprt.id == id:
+ return xprt
+
+def set_xprt_property(args):
+ xprt = get_xprt(args.id[0])
+ try:
+ if args.dstaddr != None:
+ xprt.set_dstaddr(args.dstaddr[0])
+ print(xprt)
+ except Exception as e:
+ print(e)
+
def add_command(subparser):
parser = subparser.add_parser("xprt", help="Commands for individual xprts")
parser.add_argument("--id", metavar="ID", nargs=1, type=int, help="Id of a specific xprt to show")
parser.set_defaults(func=list_xprts)
+
+ subparser = parser.add_subparsers()
+ parser = subparser.add_parser("set", help="Set an xprt property")
+ parser.add_argument("--id", metavar="ID", nargs=1, type=int, required=True, help="Id of a specific xprt to modify")
+ parser.add_argument("--dstaddr", metavar="dstaddr", nargs=1, type=str, help="New dstaddr to set")
+ parser.set_defaults(func=set_xprt_property)
--
2.33.1
next prev parent reply other threads:[~2021-10-28 18:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 18:35 [PATCH v5 0/9] Add a tool for using the new sysfs files schumaker.anna
2021-10-28 18:35 ` [PATCH v5 1/9] rpcctl: Add a rpcctl.py tool schumaker.anna
2021-10-28 18:35 ` [PATCH v5 2/9] rpcctl: Add a command for printing xprt switch information schumaker.anna
2021-10-28 18:35 ` [PATCH v5 3/9] rpcctl: Add a command for printing individual xprts schumaker.anna
2021-10-28 18:35 ` [PATCH v5 4/9] rpcctl: Add a command for printing rpc client information schumaker.anna
2021-10-28 18:35 ` schumaker.anna [this message]
2021-10-28 18:35 ` [PATCH v5 6/9] rpcctl: Add a command for changing xprt switch dstaddrs schumaker.anna
2021-10-28 18:35 ` [PATCH v5 7/9] rpcctl: Add a command for changing xprt state schumaker.anna
2021-10-28 18:35 ` [PATCH v5 8/9] rpcctl: Add a man page schumaker.anna
2021-10-28 18:35 ` [PATCH v5 9/9] rpcctl: Add installation to the Makefile schumaker.anna
2021-11-08 17:15 ` Steve Dickson
2021-11-08 17:19 ` Steve Dickson
2021-11-08 18:15 ` Anna Schumaker
2021-11-01 14:40 ` [PATCH v5 0/9] Add a tool for using the new sysfs files Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028183519.160772-6-Anna.Schumaker@Netapp.com \
--to=schumaker.anna@gmail.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox