From: Petr Vorel <pvorel@suse.cz>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: linux-nfs@vger.kernel.org, Petr Vorel <petr.vorel@gmail.com>,
Steve Dickson <steved@redhat.com>
Subject: Re: [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h>
Date: Wed, 6 Dec 2023 20:42:20 +0100 [thread overview]
Message-ID: <20231206194220.GA159824@pevik> (raw)
In-Reply-To: <be8ead05-1ebd-45c8-84e7-78b6b0e7202b@benettiengineering.com>
Hi Giulio,
> Hi Petr,
> On 05/12/23 23:35, Petr Vorel wrote:
> > From: Petr Vorel <petr.vorel@gmail.com>
> > This fixes build on systems which actually needs getrandom()
> > (to get SYS_getrandom).
> > Fixes: f92fd6ca ("support/backend_sqlite.c: Add getrandom() fallback")
> > Fixes: http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/
> > Reported-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> thank you for fixing. I've tested this and the other patch with
> Buildroot's test-pkg and built fine for many toolchain/arch/libc
> combinations.
Thank you for extensive testing! I test only the basic 6 tests (the default
test-pkg). I suppose you run test-pkg also with -a (these 45 arch
combinations).
> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Maybe you can add your Tested-by: ?
Kind regards,
Petr
> Best regards
next prev parent reply other threads:[~2023-12-06 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 22:35 [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes Petr Vorel
2023-12-05 22:35 ` [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h> Petr Vorel
2023-12-06 18:53 ` Giulio Benetti
2023-12-06 19:42 ` Petr Vorel [this message]
2023-12-06 22:24 ` Giulio Benetti
2023-12-06 18:53 ` [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes Giulio Benetti
2023-12-06 22:24 ` Giulio Benetti
2024-01-04 0:39 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206194220.GA159824@pevik \
--to=pvorel@suse.cz \
--cc=giulio.benetti@benettiengineering.com \
--cc=linux-nfs@vger.kernel.org \
--cc=petr.vorel@gmail.com \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox