From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Petr Vorel <pvorel@suse.cz>, linux-nfs@vger.kernel.org
Cc: Petr Vorel <petr.vorel@gmail.com>, Steve Dickson <steved@redhat.com>
Subject: Re: [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h>
Date: Wed, 6 Dec 2023 19:53:03 +0100 [thread overview]
Message-ID: <be8ead05-1ebd-45c8-84e7-78b6b0e7202b@benettiengineering.com> (raw)
In-Reply-To: <20231205223543.31443-2-pvorel@suse.cz>
Hi Petr,
On 05/12/23 23:35, Petr Vorel wrote:
> From: Petr Vorel <petr.vorel@gmail.com>
>
> This fixes build on systems which actually needs getrandom()
> (to get SYS_getrandom).
>
> Fixes: f92fd6ca ("support/backend_sqlite.c: Add getrandom() fallback")
> Fixes: http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/
> Reported-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
thank you for fixing. I've tested this and the other patch with
Buildroot's test-pkg and built fine for many toolchain/arch/libc
combinations.
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Best regards
--
Giulio Benetti
CEO&CTO@Benetti Engineering sas
> ---
> Changes v1->v2:
> * New commit
>
> I'm sorry for these errors.
>
> support/reexport/backend_sqlite.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/support/reexport/backend_sqlite.c b/support/reexport/backend_sqlite.c
> index 0eb5ea37..54dfe447 100644
> --- a/support/reexport/backend_sqlite.c
> +++ b/support/reexport/backend_sqlite.c
> @@ -7,6 +7,7 @@
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> +#include <sys/syscall.h>
> #include <unistd.h>
>
> #ifdef HAVE_GETRANDOM
next prev parent reply other threads:[~2023-12-06 18:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 22:35 [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes Petr Vorel
2023-12-05 22:35 ` [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h> Petr Vorel
2023-12-06 18:53 ` Giulio Benetti [this message]
2023-12-06 19:42 ` Petr Vorel
2023-12-06 22:24 ` Giulio Benetti
2023-12-06 18:53 ` [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes Giulio Benetti
2023-12-06 22:24 ` Giulio Benetti
2024-01-04 0:39 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be8ead05-1ebd-45c8-84e7-78b6b0e7202b@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=linux-nfs@vger.kernel.org \
--cc=petr.vorel@gmail.com \
--cc=pvorel@suse.cz \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox