From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Petr Vorel <pvorel@suse.cz>, linux-nfs@vger.kernel.org
Cc: Steve Dickson <steved@redhat.com>
Subject: Re: [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes
Date: Wed, 6 Dec 2023 19:53:04 +0100 [thread overview]
Message-ID: <e99577a3-b36d-4ef0-a330-88502d3193df@benettiengineering.com> (raw)
In-Reply-To: <20231205223543.31443-1-pvorel@suse.cz>
Hi Petr,
On 05/12/23 23:35, Petr Vorel wrote:
> Older uClibc-ng requires <unistd.h> for close(2), unlink(2) and write(2),
> <sys/un.h> for struct sockaddr_un.
>
> Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers")
> Fixes: bdc79f02 ("support/reexport.c: Remove unused headers")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Best regards
--
Giulio Benetti
CEO&CTO@Benetti Engineering sas
> ---
> Changes v1->v2:
> * Add also <sys/un.h>
>
> support/reexport/fsidd.c | 2 ++
> support/reexport/reexport.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c
> index 8a70b78f..51750ea3 100644
> --- a/support/reexport/fsidd.c
> +++ b/support/reexport/fsidd.c
> @@ -7,6 +7,8 @@
> #include <dlfcn.h>
> #endif
> #include <event2/event.h>
> +#include <sys/un.h>
> +#include <unistd.h>
>
> #include "conffile.h"
> #include "reexport_backend.h"
> diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c
> index 0fb49a46..c7bff6a3 100644
> --- a/support/reexport/reexport.c
> +++ b/support/reexport/reexport.c
> @@ -7,6 +7,7 @@
> #endif
> #include <sys/types.h>
> #include <sys/vfs.h>
> +#include <unistd.h>
> #include <errno.h>
>
> #include "nfsd_path.h"
next prev parent reply other threads:[~2023-12-06 18:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 22:35 [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes Petr Vorel
2023-12-05 22:35 ` [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h> Petr Vorel
2023-12-06 18:53 ` Giulio Benetti
2023-12-06 19:42 ` Petr Vorel
2023-12-06 22:24 ` Giulio Benetti
2023-12-06 18:53 ` Giulio Benetti [this message]
2023-12-06 22:24 ` [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes Giulio Benetti
2024-01-04 0:39 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e99577a3-b36d-4ef0-a330-88502d3193df@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=linux-nfs@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox