From: cel@kernel.org
To: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v1 4/4] SUNRPC: Remove svc_rqst :: rq_vec
Date: Wed, 7 May 2025 10:07:28 -0400 [thread overview]
Message-ID: <20250507140728.6497-5-cel@kernel.org> (raw)
In-Reply-To: <20250507140728.6497-1-cel@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
Clean up: This array is no longer used.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
include/linux/sunrpc/svc.h | 1 -
net/sunrpc/svc.c | 6 ------
2 files changed, 7 deletions(-)
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index 513b5ee88293..a66d13e55831 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -205,7 +205,6 @@ struct svc_rqst {
struct page * *rq_page_end; /* one past the last page */
struct folio_batch rq_fbatch;
- struct kvec *rq_vec;
struct bio_vec *rq_bvec;
__be32 rq_xid; /* transmission id */
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 77e9c180f48b..8056af53d3c0 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -673,7 +673,6 @@ svc_rqst_free(struct svc_rqst *rqstp)
{
folio_batch_release(&rqstp->rq_fbatch);
kfree(rqstp->rq_bvec);
- kfree(rqstp->rq_vec);
svc_release_buffer(rqstp);
if (rqstp->rq_scratch_page)
put_page(rqstp->rq_scratch_page);
@@ -712,11 +711,6 @@ svc_prepare_thread(struct svc_serv *serv, struct svc_pool *pool, int node)
if (!svc_init_buffer(rqstp, serv, node))
goto out_enomem;
- rqstp->rq_vec = kcalloc_node(rqstp->rq_maxpages, sizeof(struct kvec),
- GFP_KERNEL, node);
- if (!rqstp->rq_vec)
- goto out_enomem;
-
rqstp->rq_bvec = kcalloc_node(rqstp->rq_maxpages,
sizeof(struct bio_vec),
GFP_KERNEL, node);
--
2.49.0
next prev parent reply other threads:[~2025-05-07 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 14:07 [PATCH v1 0/4] Remove svc_rqst :: rq_vec cel
2025-05-07 14:07 ` [PATCH v1 1/4] NFSD: Use rqstp->rq_bvec in nfsd_iter_read() cel
2025-05-07 14:07 ` [PATCH v1 2/4] NFSD: De-duplicate the svc_fill_write_vector() call sites cel
2025-05-07 14:07 ` [PATCH v1 3/4] NFSD: Use rqstp->rq_bvec in nfsd_iter_write() cel
2025-05-08 14:26 ` Christoph Hellwig
2025-05-07 14:07 ` cel [this message]
2025-05-07 15:26 ` [PATCH v1 0/4] Remove svc_rqst :: rq_vec Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507140728.6497-5-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox