From: Christoph Hellwig <hch@infradead.org>
To: cel@kernel.org
Cc: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v1 3/4] NFSD: Use rqstp->rq_bvec in nfsd_iter_write()
Date: Thu, 8 May 2025 07:26:26 -0700 [thread overview]
Message-ID: <aBy_EuRAYrq-T_hT@infradead.org> (raw)
In-Reply-To: <20250507140728.6497-4-cel@kernel.org>
On Wed, May 07, 2025 at 10:07:27AM -0400, cel@kernel.org wrote:
> + * Fills in @rqstp->rq_bvec, and returns the number of elements it
> + * populated in that array.
> */
> unsigned int svc_fill_write_vector(struct svc_rqst *rqstp,
> const struct xdr_buf *payload)
The caller can simply use xdr_buf_to_bvec as done in my version of
this and we can kill this helper.
next prev parent reply other threads:[~2025-05-08 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 14:07 [PATCH v1 0/4] Remove svc_rqst :: rq_vec cel
2025-05-07 14:07 ` [PATCH v1 1/4] NFSD: Use rqstp->rq_bvec in nfsd_iter_read() cel
2025-05-07 14:07 ` [PATCH v1 2/4] NFSD: De-duplicate the svc_fill_write_vector() call sites cel
2025-05-07 14:07 ` [PATCH v1 3/4] NFSD: Use rqstp->rq_bvec in nfsd_iter_write() cel
2025-05-08 14:26 ` Christoph Hellwig [this message]
2025-05-07 14:07 ` [PATCH v1 4/4] SUNRPC: Remove svc_rqst :: rq_vec cel
2025-05-07 15:26 ` [PATCH v1 0/4] " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBy_EuRAYrq-T_hT@infradead.org \
--to=hch@infradead.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox