From: Jeff Layton <jlayton@kernel.org>
To: cel@kernel.org, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v1 0/4] Remove svc_rqst :: rq_vec
Date: Wed, 07 May 2025 11:26:32 -0400 [thread overview]
Message-ID: <907c96ecd344f45901f52dc1dd2e41688c35c592.camel@kernel.org> (raw)
In-Reply-To: <20250507140728.6497-1-cel@kernel.org>
On Wed, 2025-05-07 at 10:07 -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> I intend to insert these into the series that expands the maximum
> r/wsize, once they are reviewed.
>
> Testing has shown no correctness issues, but some unexpected
> performance variation that I still need to chase down.
>
Interesting.
> Chuck Lever (4):
> NFSD: Use rqstp->rq_bvec in nfsd_iter_read()
> NFSD: De-duplicate the svc_fill_write_vector() call sites
> NFSD: Use rqstp->rq_bvec in nfsd_iter_write()
> SUNRPC: Remove svc_rqst :: rq_vec
>
> fs/nfsd/nfs3proc.c | 5 +---
> fs/nfsd/nfs4proc.c | 8 ++---
> fs/nfsd/nfsproc.c | 9 ++----
> fs/nfsd/vfs.c | 61 +++++++++++++++++++++++++++-----------
> fs/nfsd/vfs.h | 10 +++----
> include/linux/sunrpc/svc.h | 3 +-
> net/sunrpc/svc.c | 33 ++++++++++-----------
> 7 files changed, 71 insertions(+), 58 deletions(-)
Either way, this seems like a good simplification and cleanup.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2025-05-07 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 14:07 [PATCH v1 0/4] Remove svc_rqst :: rq_vec cel
2025-05-07 14:07 ` [PATCH v1 1/4] NFSD: Use rqstp->rq_bvec in nfsd_iter_read() cel
2025-05-07 14:07 ` [PATCH v1 2/4] NFSD: De-duplicate the svc_fill_write_vector() call sites cel
2025-05-07 14:07 ` [PATCH v1 3/4] NFSD: Use rqstp->rq_bvec in nfsd_iter_write() cel
2025-05-08 14:26 ` Christoph Hellwig
2025-05-07 14:07 ` [PATCH v1 4/4] SUNRPC: Remove svc_rqst :: rq_vec cel
2025-05-07 15:26 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907c96ecd344f45901f52dc1dd2e41688c35c592.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox