* [PATCH] nfs-utils: add missing comma for exports ent
@ 2015-04-05 14:09 Kinglong Mee
2015-04-06 12:01 ` Christoph Hellwig
2015-04-06 21:14 ` Steve Dickson
0 siblings, 2 replies; 3+ messages in thread
From: Kinglong Mee @ 2015-04-05 14:09 UTC (permalink / raw)
To: Steve Dickson
Cc: linux-nfs@vger.kernel.org, Christoph Hellwig, J. Bruce Fields,
kinglongmee
When using pnfs with "fsid=0", exportfs prints error as,
# exportfs -a
exportfs: /var/lib/nfs/etab:1: unknown keyword "no_pnfsfsid=0"
Commit cdd16bef98 ("nfs-utils: add support for the "pnfs" export option")
miss the comma after "pnfs"/"on_pnfs" operation.
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
support/nfs/exports.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/nfs/exports.c b/support/nfs/exports.c
index 9b325b9..761a046 100644
--- a/support/nfs/exports.c
+++ b/support/nfs/exports.c
@@ -275,7 +275,7 @@ putexportent(struct exportent *ep)
"no_" : "");
if (ep->e_flags & NFSEXP_NOREADDIRPLUS)
fprintf(fp, "nordirplus,");
- fprintf(fp, "%spnfs", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
+ fprintf(fp, "%spnfs,", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
if (ep->e_flags & NFSEXP_FSID) {
fprintf(fp, "fsid=%d,", ep->e_fsid);
}
--
2.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nfs-utils: add missing comma for exports ent
2015-04-05 14:09 [PATCH] nfs-utils: add missing comma for exports ent Kinglong Mee
@ 2015-04-06 12:01 ` Christoph Hellwig
2015-04-06 21:14 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2015-04-06 12:01 UTC (permalink / raw)
To: Kinglong Mee
Cc: Steve Dickson, linux-nfs@vger.kernel.org, Christoph Hellwig,
J. Bruce Fields
Thanks, sorry for messing up the last minute update..
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nfs-utils: add missing comma for exports ent
2015-04-05 14:09 [PATCH] nfs-utils: add missing comma for exports ent Kinglong Mee
2015-04-06 12:01 ` Christoph Hellwig
@ 2015-04-06 21:14 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2015-04-06 21:14 UTC (permalink / raw)
To: Kinglong Mee
Cc: linux-nfs@vger.kernel.org, Christoph Hellwig, J. Bruce Fields
On 04/05/2015 10:09 AM, Kinglong Mee wrote:
> When using pnfs with "fsid=0", exportfs prints error as,
>
> # exportfs -a
> exportfs: /var/lib/nfs/etab:1: unknown keyword "no_pnfsfsid=0"
>
> Commit cdd16bef98 ("nfs-utils: add support for the "pnfs" export option")
> miss the comma after "pnfs"/"on_pnfs" operation.
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Committed...
steved.
> ---
> support/nfs/exports.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/nfs/exports.c b/support/nfs/exports.c
> index 9b325b9..761a046 100644
> --- a/support/nfs/exports.c
> +++ b/support/nfs/exports.c
> @@ -275,7 +275,7 @@ putexportent(struct exportent *ep)
> "no_" : "");
> if (ep->e_flags & NFSEXP_NOREADDIRPLUS)
> fprintf(fp, "nordirplus,");
> - fprintf(fp, "%spnfs", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
> + fprintf(fp, "%spnfs,", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
> if (ep->e_flags & NFSEXP_FSID) {
> fprintf(fp, "fsid=%d,", ep->e_fsid);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-06 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-05 14:09 [PATCH] nfs-utils: add missing comma for exports ent Kinglong Mee
2015-04-06 12:01 ` Christoph Hellwig
2015-04-06 21:14 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox