[PATCH] locktest: use correct build flags

[PATCH] locktest: use correct build flags

[Ross Burton]

This makefile uses CFLAGS_FOR_BUILD etc but since 2020[1] hasn't used
CC_FOR_BUILD as CC.

This means in cross-compile environments this uninstalled binary is
built for the host machine using build machine flags, which can result
in incorrect paths being passed.

As this binary hasn't been built with CC_FOR_BUILD for five years, we
can assume that this isn't actually used and just remove the _FOR_BUILD
flags entirely.

Original patch by Khem Raj <raj.khem@gmail.com>.

[1] nfs-utils 1fee8caa ("locktest: Makefile.am: remove host compiler costraint")
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 tools/locktest/Makefile.am | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am
index e8914655..2fd36971 100644
--- a/tools/locktest/Makefile.am
+++ b/tools/locktest/Makefile.am
@@ -2,8 +2,5 @@
 
 noinst_PROGRAMS = testlk
 testlk_SOURCES = testlk.c
-testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
-testlk_CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
-testlk_LDFLAGS=$(LDFLAGS_FOR_BUILD)
 
 MAINTAINERCLEANFILES = Makefile.in
-- 
2.43.0

Re: [PATCH] locktest: use correct build flags

[Jeff Layton]

On Mon, 2025-11-17 at 14:32 +0000, Ross Burton wrote:
> This makefile uses CFLAGS_FOR_BUILD etc but since 2020[1] hasn't used
> CC_FOR_BUILD as CC.
> 
> This means in cross-compile environments this uninstalled binary is
> built for the host machine using build machine flags, which can result
> in incorrect paths being passed.
> 
> As this binary hasn't been built with CC_FOR_BUILD for five years, we
> can assume that this isn't actually used and just remove the _FOR_BUILD
> flags entirely.
> 
> Original patch by Khem Raj <raj.khem@gmail.com>.
> 
> [1] nfs-utils 1fee8caa ("locktest: Makefile.am: remove host compiler costraint")
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  tools/locktest/Makefile.am | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am
> index e8914655..2fd36971 100644
> --- a/tools/locktest/Makefile.am
> +++ b/tools/locktest/Makefile.am
> @@ -2,8 +2,5 @@
>  
>  noinst_PROGRAMS = testlk
>  testlk_SOURCES = testlk.c
> -testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
> -testlk_CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
> -testlk_LDFLAGS=$(LDFLAGS_FOR_BUILD)
>  
>  MAINTAINERCLEANFILES = Makefile.in

(cc'ing SteveD since he's nfs-utils maintainer)

Acked-by: Jeff Layton <jlayton@kernel.org>

Re: [PATCH] locktest: use correct build flags

[Steve Dickson]

On 11/17/25 9:32 AM, Ross Burton wrote:
> This makefile uses CFLAGS_FOR_BUILD etc but since 2020[1] hasn't used
> CC_FOR_BUILD as CC.
> 
> This means in cross-compile environments this uninstalled binary is
> built for the host machine using build machine flags, which can result
> in incorrect paths being passed.
> 
> As this binary hasn't been built with CC_FOR_BUILD for five years, we
> can assume that this isn't actually used and just remove the _FOR_BUILD
> flags entirely.
> 
> Original patch by Khem Raj <raj.khem@gmail.com>.
> 
> [1] nfs-utils 1fee8caa ("locktest: Makefile.am: remove host compiler costraint")
> Signed-off-by: Ross Burton <ross.burton@arm.com>
Committed... (tag: nfs-utils-2-8-5-rc1)

steved.> ---
>   tools/locktest/Makefile.am | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am
> index e8914655..2fd36971 100644
> --- a/tools/locktest/Makefile.am
> +++ b/tools/locktest/Makefile.am
> @@ -2,8 +2,5 @@
>   
>   noinst_PROGRAMS = testlk
>   testlk_SOURCES = testlk.c
> -testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
> -testlk_CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
> -testlk_LDFLAGS=$(LDFLAGS_FOR_BUILD)
>   
>   MAINTAINERCLEANFILES = Makefile.in