[PATCH] nfsrahead: fix linking while static linking

[PATCH] nfsrahead: fix linking while static linking

[Giulio Benetti]

-lmount must preceed -lblkid and to obtain this let's add:
`pkg-conf --libs mount`
in place of:
`-lmount`
This ways the library order will always be correct.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 tools/nfsrahead/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
index 845ea0d5..74fc344f 100644
--- a/tools/nfsrahead/Makefile.am
+++ b/tools/nfsrahead/Makefile.am
@@ -1,6 +1,6 @@
 libexec_PROGRAMS = nfsrahead
 nfsrahead_SOURCES = main.c
-nfsrahead_LDFLAGS= -lmount
+nfsrahead_LDFLAGS= `pkg-conf --libs mount`
 nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
 
 man5_MANS = nfsrahead.man
-- 
2.34.1

Re: [PATCH] nfsrahead: fix linking while static linking

[Giulio Benetti]

Pardon, s/pkg-conf/pkg-config

I'm going to send V2

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

On 10/08/22 00:12, Giulio Benetti wrote:
> -lmount must preceed -lblkid and to obtain this let's add:
> `pkg-conf --libs mount`
> in place of:
> `-lmount`
> This ways the library order will always be correct.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   tools/nfsrahead/Makefile.am | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
> index 845ea0d5..74fc344f 100644
> --- a/tools/nfsrahead/Makefile.am
> +++ b/tools/nfsrahead/Makefile.am
> @@ -1,6 +1,6 @@
>   libexec_PROGRAMS = nfsrahead
>   nfsrahead_SOURCES = main.c
> -nfsrahead_LDFLAGS= -lmount
> +nfsrahead_LDFLAGS= `pkg-conf --libs mount`
>   nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
>   
>   man5_MANS = nfsrahead.man

[PATCH v2] nfsrahead: fix linking while static linking

[Giulio Benetti]

-lmount must preceed -lblkid and to obtain this let's add:
`pkg-config --libs mount`
in place of:
`-lmount`
This ways the library order will always be correct.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* modify pkg-conf to pkg-config
---
 tools/nfsrahead/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
index 845ea0d5..280a2eb4 100644
--- a/tools/nfsrahead/Makefile.am
+++ b/tools/nfsrahead/Makefile.am
@@ -1,6 +1,6 @@
 libexec_PROGRAMS = nfsrahead
 nfsrahead_SOURCES = main.c
-nfsrahead_LDFLAGS= -lmount
+nfsrahead_LDFLAGS= `pkg-config --libs mount`
 nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
 
 man5_MANS = nfsrahead.man
-- 
2.34.1

Re: [PATCH v2] nfsrahead: fix linking while static linking

[Giulio Benetti]

Hi All,

please drop this patch in favor of upcoming V3. This is not a good way
to use pkg-config with Autotools.

Sorry for the noise

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

On 10/08/22 00:33, Giulio Benetti wrote:
> -lmount must preceed -lblkid and to obtain this let's add:
> `pkg-config --libs mount`
> in place of:
> `-lmount`
> This ways the library order will always be correct.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * modify pkg-conf to pkg-config
> ---
>   tools/nfsrahead/Makefile.am | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
> index 845ea0d5..280a2eb4 100644
> --- a/tools/nfsrahead/Makefile.am
> +++ b/tools/nfsrahead/Makefile.am
> @@ -1,6 +1,6 @@
>   libexec_PROGRAMS = nfsrahead
>   nfsrahead_SOURCES = main.c
> -nfsrahead_LDFLAGS= -lmount
> +nfsrahead_LDFLAGS= `pkg-config --libs mount`
>   nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
>   
>   man5_MANS = nfsrahead.man

[PATCH v3] nfsrahead: fix linking while static linking

[Giulio Benetti]

-lmount must preceed -lblkid and to obtain this let's add in configure.ac:
PKG_CHECK_MODULES([LIBMOUNT], [mount])
and in tools/nfsrahead/Makefile.am let's substitute explicit `-lmount`
with:
$(LIBMOUNT_LIBS)
This way all the required libraries will be present and in the right order
when static linking.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* modify pkg-conf to pkg-config
V2->V3:
* use the correct way for using pkg-config with Autotools
---
 configure.ac                | 3 +++
 tools/nfsrahead/Makefile.am | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index f1c46c5c..ff85200b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -273,6 +273,9 @@ AC_LIBCAP
 dnl Check for -lxml2
 AC_LIBXML2
 
+dnl Check for -lmount
+PKG_CHECK_MODULES([LIBMOUNT], [mount])
+
 # Check whether user wants TCP wrappers support
 AC_TCP_WRAPPERS
 
diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
index 845ea0d5..7e08233a 100644
--- a/tools/nfsrahead/Makefile.am
+++ b/tools/nfsrahead/Makefile.am
@@ -1,6 +1,6 @@
 libexec_PROGRAMS = nfsrahead
 nfsrahead_SOURCES = main.c
-nfsrahead_LDFLAGS= -lmount
+nfsrahead_LDFLAGS= $(LIBMOUNT_LIBS)
 nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
 
 man5_MANS = nfsrahead.man
-- 
2.34.1

Re: [PATCH v3] nfsrahead: fix linking while static linking

[Petr Vorel]

Hi,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

nit (not worth of reposting): I'm not a native speaker, but IMHO subject should
be without while, e.g. "fix order on static linking"

Kind regards,
Petr

Re: [PATCH v3] nfsrahead: fix linking while static linking

[Giulio Benetti]

Hi Petr,

> Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <pvorel@suse.cz> ha scritto:
> 
> Hi,
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> nit (not worth of reposting): I'm not a native speaker, but IMHO subject should
> be without while, e.g. "fix order on static linking"

Totally, it sounds awful as it is now.
I ask maintainers if it’s possible to reword like Petr
pointed.

Thank you all.

Best regards
Giulio

> 
> Kind regards,
> Petr

Re: [PATCH v3] nfsrahead: fix linking while static linking

[Steve Dickson]

On 8/11/22 4:36 PM, Giulio Benetti wrote:
> Hi Petr,
> 
>> Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <pvorel@suse.cz> ha scritto:
>>
>> Hi,
>>
>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>
>> nit (not worth of reposting): I'm not a native speaker, but IMHO subject should
>> be without while, e.g. "fix order on static linking"
> 
> Totally, it sounds awful as it is now.
> I ask maintainers if it’s possible to reword like Petr
> pointed.
Will do!

steved.
> 
> Thank you all.
> 
> Best regards
> Giulio
> 
>>
>> Kind regards,
>> Petr
> 

Re: [PATCH v3] nfsrahead: fix linking while static linking

[Giulio Benetti]

Hi Steve, Petr,

On 22/08/22 21:17, Steve Dickson wrote:
> 
> 
> On 8/11/22 4:36 PM, Giulio Benetti wrote:
>> Hi Petr,
>>
>>> Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <pvorel@suse.cz> ha 
>>> scritto:
>>>
>>> Hi,
>>>
>>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>>
>>> nit (not worth of reposting): I'm not a native speaker, but IMHO 
>>> subject should
>>> be without while, e.g. "fix order on static linking"
>>
>> Totally, it sounds awful as it is now.
>> I ask maintainers if it’s possible to reword like Petr
>> pointed.
> Will do!

Thank you!

I will try to improve the pkg-config autotools because as it is now it 
works but it’s not a good solution.

I should use what it’s been suggested to me here:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
And I’ve given another solution:
https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
but it’s still not ok:
https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.html

So for the moment it’s a decent solution indeed it’s been committed to 
Buildroot
but I’ll try to improve it once I’ll have time.

Kind regards
—
Giulio Benetti
CEO/CTO@Benetti Engineering sas

> steved.
>>
>> Thank you all.
>>
>> Best regards
>> Giulio
>>
>>>
>>> Kind regards,
>>> Petr
>>
> 

-- 
Giulio Benetti
Benetti Engineering sas

Re: [PATCH v3] nfsrahead: fix linking while static linking

[Steve Dickson]

On 8/22/22 4:33 PM, Giulio Benetti wrote:
> Hi Steve, Petr,
> 
> On 22/08/22 21:17, Steve Dickson wrote:
>>
>>
>> On 8/11/22 4:36 PM, Giulio Benetti wrote:
>>> Hi Petr,
>>>
>>>> Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel <pvorel@suse.cz> 
>>>> ha scritto:
>>>>
>>>> Hi,
>>>>
>>>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>>>
>>>> nit (not worth of reposting): I'm not a native speaker, but IMHO 
>>>> subject should
>>>> be without while, e.g. "fix order on static linking"
>>>
>>> Totally, it sounds awful as it is now.
>>> I ask maintainers if it’s possible to reword like Petr
>>> pointed.
>> Will do!
> 
> Thank you!
> 
> I will try to improve the pkg-config autotools because as it is now it 
> works but it’s not a good solution.
> 
> I should use what it’s been suggested to me here:
> https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
> And I’ve given another solution:
> https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
> but it’s still not ok:
> https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.html
I don't have access to those list...

> 
> So for the moment it’s a decent solution indeed it’s been committed to 
> Buildroot
> but I’ll try to improve it once I’ll have time.
Sounds like a plan...

steved.

> 
> Kind regards
> —
> Giulio Benetti
> CEO/CTO@Benetti Engineering sas
> 
>> steved.
>>>
>>> Thank you all.
>>>
>>> Best regards
>>> Giulio
>>>
>>>>
>>>> Kind regards,
>>>> Petr
>>>
>>
> 

Re: [PATCH v3] nfsrahead: fix linking while static linking

[Petr Vorel]

> On 8/22/22 4:33 PM, Giulio Benetti wrote:
> > Hi Steve, Petr,

> > On 22/08/22 21:17, Steve Dickson wrote:


> > > On 8/11/22 4:36 PM, Giulio Benetti wrote:
> > > > Hi Petr,

> > > > > Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel
> > > > > <pvorel@suse.cz> ha scritto:

> > > > > Hi,

> > > > > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > > > > nit (not worth of reposting): I'm not a native speaker, but
> > > > > IMHO subject should
> > > > > be without while, e.g. "fix order on static linking"

> > > > Totally, it sounds awful as it is now.
> > > > I ask maintainers if it’s possible to reword like Petr
> > > > pointed.
> > > Will do!

> > Thank you!

> > I will try to improve the pkg-config autotools because as it is now it
> > works but it’s not a good solution.

> > I should use what it’s been suggested to me here:
> > https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
> > And I’ve given another solution:
> > https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
> > but it’s still not ok:
> > https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.html
> I don't have access to those list...

Yep, these are forbidden 403.
Giulio, please post a link on lore
https://lore.kernel.org/buildroot/
(or on patchwork)

Kind regards,
Petr


> > So for the moment it’s a decent solution indeed it’s been committed to
> > Buildroot
> > but I’ll try to improve it once I’ll have time.
> Sounds like a plan...

> steved.


> > Kind regards
> > —
> > Giulio Benetti
> > CEO/CTO@Benetti Engineering sas

> > > steved.

> > > > Thank you all.

> > > > Best regards
> > > > Giulio


> > > > > Kind regards,
> > > > > Petr

Re: [PATCH v3] nfsrahead: fix linking while static linking

[Giulio Benetti]

Hi Petr, Steve, All,

On 13/09/22 17:56, Petr Vorel wrote:
> 
> 
>> On 8/22/22 4:33 PM, Giulio Benetti wrote:
>>> Hi Steve, Petr,
> 
>>> On 22/08/22 21:17, Steve Dickson wrote:
> 
> 
>>>> On 8/11/22 4:36 PM, Giulio Benetti wrote:
>>>>> Hi Petr,
> 
>>>>>> Il giorno 11 ago 2022, alle ore 22:20, Petr Vorel
>>>>>> <pvorel@suse.cz> ha scritto:
> 
>>>>>> Hi,
> 
>>>>>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
>>>>>> nit (not worth of reposting): I'm not a native speaker, but
>>>>>> IMHO subject should
>>>>>> be without while, e.g. "fix order on static linking"
> 
>>>>> Totally, it sounds awful as it is now.
>>>>> I ask maintainers if it’s possible to reword like Petr
>>>>> pointed.
>>>> Will do!
> 
>>> Thank you!
> 
>>> I will try to improve the pkg-config autotools because as it is now it
>>> works but it’s not a good solution.
> 
>>> I should use what it’s been suggested to me here:
>>> https://lists.buildroot.org/pipermail/buildroot/2022-August/648926.html
>>> And I’ve given another solution:
>>> https://lists.buildroot.org/pipermail/buildroot/2022-August/648933.html
>>> but it’s still not ok:
>>> https://lists.buildroot.org/pipermail/buildroot/2022-August/649058.html
>> I don't have access to those list...
> 
> Yep, these are forbidden 403.
> Giulio, please post a link on lore
> https://lore.kernel.org/buildroot/
> (or on patchwork)

Oops, you're both right, thank you Petr.

Follows lore links:

I should use what it’s been suggested to me here:
https://lore.kernel.org/buildroot/20220810231839.1b6164f7@windsurf/
And I’ve given another solution:
https://lore.kernel.org/buildroot/20220810215104.107714-1-giulio.benetti@benettiengineering.com/
but it’s still not ok:
https://lore.kernel.org/buildroot/20220811224752.1a1e53b7@windsurf/

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

Re: [PATCH v3] nfsrahead: fix linking while static linking

[Steve Dickson]

On 8/10/22 5:45 PM, Giulio Benetti wrote:
> -lmount must preceed -lblkid and to obtain this let's add in configure.ac:
> PKG_CHECK_MODULES([LIBMOUNT], [mount])
> and in tools/nfsrahead/Makefile.am let's substitute explicit `-lmount`
> with:
> $(LIBMOUNT_LIBS)
> This way all the required libraries will be present and in the right order
> when static linking.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed... (tag: nfs-utils-2-6-3-rc1)

steved
> ---
> V1->V2:
> * modify pkg-conf to pkg-config
> V2->V3:
> * use the correct way for using pkg-config with Autotools
> ---
>   configure.ac                | 3 +++
>   tools/nfsrahead/Makefile.am | 2 +-
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index f1c46c5c..ff85200b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -273,6 +273,9 @@ AC_LIBCAP
>   dnl Check for -lxml2
>   AC_LIBXML2
>   
> +dnl Check for -lmount
> +PKG_CHECK_MODULES([LIBMOUNT], [mount])
> +
>   # Check whether user wants TCP wrappers support
>   AC_TCP_WRAPPERS
>   
> diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
> index 845ea0d5..7e08233a 100644
> --- a/tools/nfsrahead/Makefile.am
> +++ b/tools/nfsrahead/Makefile.am
> @@ -1,6 +1,6 @@
>   libexec_PROGRAMS = nfsrahead
>   nfsrahead_SOURCES = main.c
> -nfsrahead_LDFLAGS= -lmount
> +nfsrahead_LDFLAGS= $(LIBMOUNT_LIBS)
>   nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
>   
>   man5_MANS = nfsrahead.man