* [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
@ 2013-08-13 13:50 Vyacheslav Dubeyko
2013-08-13 16:51 ` Ryusuke Konishi
0 siblings, 1 reply; 6+ messages in thread
From: Vyacheslav Dubeyko @ 2013-08-13 13:50 UTC (permalink / raw)
To: Ryusuke Konishi
Cc: DanCarpenter, linux-nilfs, Linux FS Devel, kernel-janitors, akpm
From: Vyacheslav Dubeyko <slava@dubeyko.com>
Subject: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
This patch removes double call of bio_put() in nilfs_end_bio_write()
for the case of BIO_EOPNOTSUPP error detection. The issue was found
by Dan Carpenter and he suggests first version of the fix too.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
---
fs/nilfs2/segbuf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
index dc9a913..5bacf46 100644
--- a/fs/nilfs2/segbuf.c
+++ b/fs/nilfs2/segbuf.c
@@ -345,8 +345,7 @@ static void nilfs_end_bio_write(struct bio *bio, int err)
if (err == -EOPNOTSUPP) {
set_bit(BIO_EOPNOTSUPP, &bio->bi_flags);
- bio_put(bio);
- /* to be detected by submit_seg_bio() */
+ /* to be detected by nilfs_segbuf_submit_bio() */
}
if (!uptodate)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
2013-08-13 13:50 [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error Vyacheslav Dubeyko
@ 2013-08-13 16:51 ` Ryusuke Konishi
2013-08-14 23:00 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Ryusuke Konishi @ 2013-08-13 16:51 UTC (permalink / raw)
To: Vyacheslav Dubeyko, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
Cc: DanCarpenter, linux-nilfs-u79uwXL29TY76Z2rM5mHXA, Linux FS Devel,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Tue, 13 Aug 2013 17:50:33 +0400, Vyacheslav Dubeyko wrote:
> From: Vyacheslav Dubeyko <slava-yeENwD64cLxBDgjK7y7TUQ@public.gmane.org>
> Subject: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
>
> This patch removes double call of bio_put() in nilfs_end_bio_write()
> for the case of BIO_EOPNOTSUPP error detection. The issue was found
> by Dan Carpenter and he suggests first version of the fix too.
>
> Reported-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Vyacheslav Dubeyko <slava-yeENwD64cLxBDgjK7y7TUQ@public.gmane.org>
> CC: Ryusuke Konishi <konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Acked-by: Ryusuke Konishi <konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Tested-by: Ryusuke Konishi <konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
I tested this patch by inserting a pseudo EOPNOTSUPP error, and this
actually fixed a crach "kernel BUG at fs/bio.c:498!" due to reference
count underflow of bio_put() that nilfs_end_bio_write() induced.
Andrew, please pick up this bug-fix preferably for this cycle.
Thanks,
Ryusuke Konishi
> ---
> fs/nilfs2/segbuf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
> index dc9a913..5bacf46 100644
> --- a/fs/nilfs2/segbuf.c
> +++ b/fs/nilfs2/segbuf.c
> @@ -345,8 +345,7 @@ static void nilfs_end_bio_write(struct bio *bio, int err)
>
> if (err == -EOPNOTSUPP) {
> set_bit(BIO_EOPNOTSUPP, &bio->bi_flags);
> - bio_put(bio);
> - /* to be detected by submit_seg_bio() */
> + /* to be detected by nilfs_segbuf_submit_bio() */
> }
>
> if (!uptodate)
> --
> 1.7.9.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
2013-08-13 16:51 ` Ryusuke Konishi
@ 2013-08-14 23:00 ` Andrew Morton
2013-08-14 23:41 ` Ryusuke Konishi
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2013-08-14 23:00 UTC (permalink / raw)
To: Ryusuke Konishi
Cc: Vyacheslav Dubeyko, DanCarpenter, linux-nilfs, Linux FS Devel,
kernel-janitors
On Wed, 14 Aug 2013 01:51:48 +0900 (JST) Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> wrote:
> On Tue, 13 Aug 2013 17:50:33 +0400, Vyacheslav Dubeyko wrote:
> > From: Vyacheslav Dubeyko <slava@dubeyko.com>
> > Subject: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
> >
> > This patch removes double call of bio_put() in nilfs_end_bio_write()
> > for the case of BIO_EOPNOTSUPP error detection. The issue was found
> > by Dan Carpenter and he suggests first version of the fix too.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
> > CC: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
>
> Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> Tested-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
>
> I tested this patch by inserting a pseudo EOPNOTSUPP error, and this
> actually fixed a crach "kernel BUG at fs/bio.c:498!" due to reference
> count underflow of bio_put() that nilfs_end_bio_write() induced.
>
>
> Andrew, please pick up this bug-fix preferably for this cycle.
Should we apply the fix to earlier kernel versions and if so, how
far back in time does it go?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
2013-08-14 23:00 ` Andrew Morton
@ 2013-08-14 23:41 ` Ryusuke Konishi
[not found] ` <20130815.084112.220043622.konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Ryusuke Konishi @ 2013-08-14 23:41 UTC (permalink / raw)
To: Andrew Morton
Cc: Vyacheslav Dubeyko, DanCarpenter, linux-nilfs, Linux FS Devel,
kernel-janitors
On Wed, 14 Aug 2013 16:00:01 -0700, Andrew Morton wrote:
> On Wed, 14 Aug 2013 01:51:48 +0900 (JST) Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> wrote:
>
>> On Tue, 13 Aug 2013 17:50:33 +0400, Vyacheslav Dubeyko wrote:
>> > From: Vyacheslav Dubeyko <slava@dubeyko.com>
>> > Subject: [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
>> >
>> > This patch removes double call of bio_put() in nilfs_end_bio_write()
>> > for the case of BIO_EOPNOTSUPP error detection. The issue was found
>> > by Dan Carpenter and he suggests first version of the fix too.
>> >
>> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> > Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
>> > CC: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
>>
>> Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
>> Tested-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
>>
>> I tested this patch by inserting a pseudo EOPNOTSUPP error, and this
>> actually fixed a crach "kernel BUG at fs/bio.c:498!" due to reference
>> count underflow of bio_put() that nilfs_end_bio_write() induced.
>>
>>
>> Andrew, please pick up this bug-fix preferably for this cycle.
>
> Should we apply the fix to earlier kernel versions and if so, how
> far back in time does it go?
Yes, I think it should also be applied to earlier versions.
I looked back ealiear versions.
This bug, unfortunately, comes from the original version (2.6.30), and
the patch could be applied to all versions.
Regards,
Ryusuke Konishi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-15 0:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-13 13:50 [PATCH v3 1/2] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error Vyacheslav Dubeyko
2013-08-13 16:51 ` Ryusuke Konishi
2013-08-14 23:00 ` Andrew Morton
2013-08-14 23:41 ` Ryusuke Konishi
[not found] ` <20130815.084112.220043622.konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2013-08-14 23:45 ` Andrew Morton
2013-08-15 0:25 ` Ryusuke Konishi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox