* [PATCH 02/12] nilfs2: Storage class should be before const qualifier
@ 2009-12-23 12:57 Tobias Klauser
[not found] ` <1261573067-8673-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Klauser @ 2009-12-23 12:57 UTC (permalink / raw)
To: KONISHI Ryusuke; +Cc: Tobias Klauser, users-JrjvKiOkagjYtjvyW6yDsg
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.
Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
---
fs/nilfs2/ioctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
index f6af760..d6b2b83 100644
--- a/fs/nilfs2/ioctl.c
+++ b/fs/nilfs2/ioctl.c
@@ -480,7 +480,7 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp,
unsigned int cmd, void __user *argp)
{
struct nilfs_argv argv[5];
- const static size_t argsz[5] = {
+ static const size_t argsz[5] = {
sizeof(struct nilfs_vdesc),
sizeof(struct nilfs_period),
sizeof(__u64),
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 02/12] nilfs2: Storage class should be before const qualifier
[not found] ` <1261573067-8673-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
@ 2009-12-23 13:01 ` Tobias Klauser
2009-12-23 14:55 ` Ryusuke Konishi
1 sibling, 0 replies; 3+ messages in thread
From: Tobias Klauser @ 2009-12-23 13:01 UTC (permalink / raw)
To: KONISHI Ryusuke; +Cc: users-JrjvKiOkagjYtjvyW6yDsg
> Subject: Re: [PATCH 02/12] nilfs2: Storage class should be before const
> qualifier
Sorry, this should jsut have been [PATCH], not [PATCH 02/12]. The
remaining patches are not targeted at nilfs.
Cheers, Tobias
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 02/12] nilfs2: Storage class should be before const qualifier
[not found] ` <1261573067-8673-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
2009-12-23 13:01 ` Tobias Klauser
@ 2009-12-23 14:55 ` Ryusuke Konishi
1 sibling, 0 replies; 3+ messages in thread
From: Ryusuke Konishi @ 2009-12-23 14:55 UTC (permalink / raw)
To: users-JrjvKiOkagjYtjvyW6yDsg, tklauser-93Khv+1bN0NyDzI6CaY1VQ
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA,
konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg
On Wed, 23 Dec 2009 13:57:47 +0100, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
Applied. Thank you!
Ryusuke Konishi
> ---
> fs/nilfs2/ioctl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
> index f6af760..d6b2b83 100644
> --- a/fs/nilfs2/ioctl.c
> +++ b/fs/nilfs2/ioctl.c
> @@ -480,7 +480,7 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp,
> unsigned int cmd, void __user *argp)
> {
> struct nilfs_argv argv[5];
> - const static size_t argsz[5] = {
> + static const size_t argsz[5] = {
> sizeof(struct nilfs_vdesc),
> sizeof(struct nilfs_period),
> sizeof(__u64),
> --
> 1.6.3.3
On Wed, 23 Dec 2009 14:01:05 +0100, Tobias Klauser wrote:
> > Subject: Re: [PATCH 02/12] nilfs2: Storage class should be before const
> > qualifier
>
> Sorry, this should jsut have been [PATCH], not [PATCH 02/12]. The
> remaining patches are not targeted at nilfs.
>
> Cheers, Tobias
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-23 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-23 12:57 [PATCH 02/12] nilfs2: Storage class should be before const qualifier Tobias Klauser
[not found] ` <1261573067-8673-1-git-send-email-tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
2009-12-23 13:01 ` Tobias Klauser
2009-12-23 14:55 ` Ryusuke Konishi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox