* [PATCH] acpi/nfit: Use kobj_to_dev() instead
@ 2020-08-13 2:49 Wang Qing
2020-08-14 15:28 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Wang Qing @ 2020-08-13 2:49 UTC (permalink / raw)
To: Dan Williams, Vishal Verma, Dave Jiang, Ira Weiny,
Rafael J. Wysocki, Len Brown, linux-nvdimm, linux-acpi,
linux-kernel
Cc: Wang Qing
Use kobj_to_dev() instead of container_of()
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/acpi/nfit/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index fa4500f..3bb350b
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus)
static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev);
if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus))
@@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = {
static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj,
struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct nvdimm *nvdimm = to_nvdimm(dev);
struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
--
2.7.4
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] acpi/nfit: Use kobj_to_dev() instead
2020-08-13 2:49 [PATCH] acpi/nfit: Use kobj_to_dev() instead Wang Qing
@ 2020-08-14 15:28 ` Rafael J. Wysocki
2020-08-14 22:52 ` Verma, Vishal L
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2020-08-14 15:28 UTC (permalink / raw)
To: Wang Qing, Dan Williams
Cc: Rafael J. Wysocki, Len Brown, linux-nvdimm@lists.01.org,
ACPI Devel Maling List, Linux Kernel Mailing List
On Thu, Aug 13, 2020 at 4:54 AM Wang Qing <wangqing@vivo.com> wrote:
>
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
LGTM
Dan, any objections?
> ---
> drivers/acpi/nfit/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index fa4500f..3bb350b
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus)
>
> static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev);
>
> if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus))
> @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = {
> static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj,
> struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct nvdimm *nvdimm = to_nvdimm(dev);
> struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
>
> --
> 2.7.4
>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] acpi/nfit: Use kobj_to_dev() instead
2020-08-14 15:28 ` Rafael J. Wysocki
@ 2020-08-14 22:52 ` Verma, Vishal L
2020-09-15 17:39 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Verma, Vishal L @ 2020-08-14 22:52 UTC (permalink / raw)
To: Williams, Dan J, rafael@kernel.org, wangqing@vivo.com
Cc: linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org,
lenb@kernel.org, linux-kernel@vger.kernel.org, rjw@rjwysocki.net
On Fri, 2020-08-14 at 17:28 +0200, Rafael J. Wysocki wrote:
> On Thu, Aug 13, 2020 at 4:54 AM Wang Qing <wangqing@vivo.com> wrote:
> > Use kobj_to_dev() instead of container_of()
> >
> > Signed-off-by: Wang Qing <wangqing@vivo.com>
>
> LGTM
>
> Dan, any objections?
Looks good to me - you can add:
Acked-by: Vishal Verma <vishal.l.verma@intel.com>
>
> > ---
> > drivers/acpi/nfit/core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index fa4500f..3bb350b
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus)
> >
> > static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n)
> > {
> > - struct device *dev = container_of(kobj, struct device, kobj);
> > + struct device *dev = kobj_to_dev(kobj);
> > struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev);
> >
> > if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus))
> > @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = {
> > static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj,
> > struct attribute *a, int n)
> > {
> > - struct device *dev = container_of(kobj, struct device, kobj);
> > + struct device *dev = kobj_to_dev(kobj);
> > struct nvdimm *nvdimm = to_nvdimm(dev);
> > struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> >
> > --
> > 2.7.4
> >
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] acpi/nfit: Use kobj_to_dev() instead
2020-08-14 22:52 ` Verma, Vishal L
@ 2020-09-15 17:39 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2020-09-15 17:39 UTC (permalink / raw)
To: Verma, Vishal L, wangqing@vivo.com
Cc: rafael@kernel.org, linux-acpi@vger.kernel.org,
linux-nvdimm@lists.01.org, lenb@kernel.org,
linux-kernel@vger.kernel.org, rjw@rjwysocki.net
On Sat, Aug 15, 2020 at 12:52 AM Verma, Vishal L
<vishal.l.verma@intel.com> wrote:
>
> On Fri, 2020-08-14 at 17:28 +0200, Rafael J. Wysocki wrote:
> > On Thu, Aug 13, 2020 at 4:54 AM Wang Qing <wangqing@vivo.com> wrote:
> > > Use kobj_to_dev() instead of container_of()
> > >
> > > Signed-off-by: Wang Qing <wangqing@vivo.com>
> >
> > LGTM
> >
> > Dan, any objections?
>
> Looks good to me - you can add:
> Acked-by: Vishal Verma <vishal.l.verma@intel.com>
Applied as 5.10 material, thanks!
> > > ---
> > > drivers/acpi/nfit/core.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > > index fa4500f..3bb350b
> > > --- a/drivers/acpi/nfit/core.c
> > > +++ b/drivers/acpi/nfit/core.c
> > > @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus)
> > >
> > > static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n)
> > > {
> > > - struct device *dev = container_of(kobj, struct device, kobj);
> > > + struct device *dev = kobj_to_dev(kobj);
> > > struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev);
> > >
> > > if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus))
> > > @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = {
> > > static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj,
> > > struct attribute *a, int n)
> > > {
> > > - struct device *dev = container_of(kobj, struct device, kobj);
> > > + struct device *dev = kobj_to_dev(kobj);
> > > struct nvdimm *nvdimm = to_nvdimm(dev);
> > > struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
> > >
> > > --
> > > 2.7.4
> > >
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-15 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-13 2:49 [PATCH] acpi/nfit: Use kobj_to_dev() instead Wang Qing
2020-08-14 15:28 ` Rafael J. Wysocki
2020-08-14 22:52 ` Verma, Vishal L
2020-09-15 17:39 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox