Re: [RFC PATCHv3 3/3] nvme: rename nvme_mpath_shutdown_disk to nvme_mpath_remove_disk

[Hannes Reinecke <hare@suse.de>]

On 5/4/25 19:50, Nilay Shroff wrote:
> In the NVMe context, the term "shutdown" has a specific technical
> meaning. To avoid confusion, this commit renames the nvme_mpath_
> shutdown_disk function to nvme_mpath_remove_disk to better reflect
> its purpose (i.e. removing the disk from the system). However,
> nvme_mpath_remove_disk was already in use, and its functionality
> is related to releasing or putting the head node disk. To resolve
> this naming conflict and improve clarity, the existing nvme_mpath_
> remove_disk function is also renamed to nvme_mpath_put_disk.
> 
> This renaming improves code readability and better aligns function
> names with their actual roles.
> 
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
> ---
>   drivers/nvme/host/core.c      |  4 ++--
>   drivers/nvme/host/multipath.c | 16 ++++++++--------
>   drivers/nvme/host/nvme.h      |  8 ++++----
>   3 files changed, 14 insertions(+), 14 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich