From: Christoph Hellwig <hch@lst.de>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, kbusch@kernel.org,
sagi@grimberg.me, jmeneghi@redhat.com, axboe@kernel.dk,
martin.petersen@oracle.com, gjoyce@ibm.com
Subject: Re: [RFC PATCHv3 1/3] nvme-multipath: introduce delayed removal of the multipath head node
Date: Thu, 8 May 2025 07:33:03 +0200 [thread overview]
Message-ID: <20250508053303.GA27661@lst.de> (raw)
In-Reply-To: <6fa58716-8995-43b9-b01e-3bbcf2cc6b2f@linux.ibm.com>
On Thu, May 08, 2025 at 01:26:16AM +0530, Nilay Shroff wrote:
> That's a possible approach; however, the challenge arises when the head node
> points to multiple namespace paths, each associated with different fabric
> controllers.
That's generally a good point. Especially PCIe vs fabrics will be
fun to test. We really need a PCI loop device for nvmet to be able
to test it.
> As we know, max_reconnects is a per-controller attribute. So, if only one of
> the fabric controllers has max_reconnects set to a non-zero value, but others
> do not, how do we decide whether to implicitly disable head->delayed_removal_secs?
Well, as soon as something in the subsystems can't reconnect we want to
delay the removal, right?
next prev parent reply other threads:[~2025-05-08 5:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 17:50 [RFC PATCHv3 0/3] improve NVMe multipath handling Nilay Shroff
2025-05-04 17:50 ` [RFC PATCHv3 1/3] nvme-multipath: introduce delayed removal of the multipath head node Nilay Shroff
2025-05-05 6:39 ` Hannes Reinecke
2025-05-06 8:28 ` Nilay Shroff
2025-05-07 6:50 ` Christoph Hellwig
2025-05-07 19:56 ` Nilay Shroff
2025-05-08 5:33 ` Christoph Hellwig [this message]
2025-05-08 15:11 ` Nilay Shroff
2025-05-04 17:50 ` [RFC PATCHv3 2/3] nvme: introduce multipath_always_on module param Nilay Shroff
2025-05-05 6:24 ` Hannes Reinecke
2025-05-07 6:51 ` Christoph Hellwig
2025-05-04 17:50 ` [RFC PATCHv3 3/3] nvme: rename nvme_mpath_shutdown_disk to nvme_mpath_remove_disk Nilay Shroff
2025-05-05 6:39 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508053303.GA27661@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox