From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Nilay Shroff <nilay@linux.ibm.com>,
linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org,
sagi@grimberg.me, jmeneghi@redhat.com, axboe@kernel.dk,
martin.petersen@oracle.com, gjoyce@ibm.com
Subject: Re: [RFC PATCHv3 1/3] nvme-multipath: introduce delayed removal of the multipath head node
Date: Wed, 7 May 2025 08:50:50 +0200 [thread overview]
Message-ID: <20250507065050.GA31543@lst.de> (raw)
In-Reply-To: <dd7330a2-6499-4af7-af3a-489ab86d2b5f@suse.de>
On Mon, May 05, 2025 at 08:39:11AM +0200, Hannes Reinecke wrote:
>> + if (ctrl->ops->flags & NVME_F_FABRICS)
>> + nvme_mpath_set_fabrics(head);
>>
>
> Please make this a separate patch.
Absolutelty not if we keep this, as there is no other user.
But I still don't like the fabrics special casing at all.
I'd much rather just disable it if opts is present and max_reconnects
is set to non-0.
next prev parent reply other threads:[~2025-05-07 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 17:50 [RFC PATCHv3 0/3] improve NVMe multipath handling Nilay Shroff
2025-05-04 17:50 ` [RFC PATCHv3 1/3] nvme-multipath: introduce delayed removal of the multipath head node Nilay Shroff
2025-05-05 6:39 ` Hannes Reinecke
2025-05-06 8:28 ` Nilay Shroff
2025-05-07 6:50 ` Christoph Hellwig [this message]
2025-05-07 19:56 ` Nilay Shroff
2025-05-08 5:33 ` Christoph Hellwig
2025-05-08 15:11 ` Nilay Shroff
2025-05-04 17:50 ` [RFC PATCHv3 2/3] nvme: introduce multipath_always_on module param Nilay Shroff
2025-05-05 6:24 ` Hannes Reinecke
2025-05-07 6:51 ` Christoph Hellwig
2025-05-04 17:50 ` [RFC PATCHv3 3/3] nvme: rename nvme_mpath_shutdown_disk to nvme_mpath_remove_disk Nilay Shroff
2025-05-05 6:39 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507065050.GA31543@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gjoyce@ibm.com \
--cc=hare@suse.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox