From: Chao Leng <lengchao@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org
Subject: Re: [PATCH v4 1/5] blk-mq: introduce blk_mq_set_request_complete
Date: Thu, 28 Jan 2021 09:34:27 +0800 [thread overview]
Message-ID: <15301bba-f7db-a0c9-c7fa-6efaafefd21c@huawei.com> (raw)
In-Reply-To: <20210127164020.GA23417@lst.de>
On 2021/1/28 0:40, Christoph Hellwig wrote:
>> +static inline void blk_mq_set_request_complete(struct request *rq)
>> +{
>> + WRITE_ONCE(rq->state, MQ_RQ_COMPLETE);
>> +}
>
> This function needs a detailed comment explaining the use case.
> Otherwise we'll get lots of driver abuses.
ok, thanks.
> .
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-28 1:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 8:15 [PATCH v4 0/5] avoid double request completion and IO error Chao Leng
2021-01-26 8:15 ` [PATCH v4 1/5] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-01-27 16:40 ` Christoph Hellwig
2021-01-28 1:34 ` Chao Leng [this message]
2021-01-26 8:15 ` [PATCH v4 2/5] nvme-core: introduce complete failed request Chao Leng
2021-01-26 8:15 ` [PATCH v4 3/5] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command Chao Leng
2021-01-26 8:15 ` [PATCH v4 4/5] nvme-rdma: avoid IO error for nvme native multipath Chao Leng
2021-01-28 8:39 ` Sagi Grimberg
2021-01-28 9:31 ` Chao Leng
2021-01-29 1:35 ` Sagi Grimberg
2021-01-29 2:48 ` Chao Leng
2021-01-29 3:24 ` Sagi Grimberg
2021-01-29 3:30 ` Chao Leng
2021-01-29 3:37 ` Sagi Grimberg
2021-01-29 3:50 ` Chao Leng
2021-01-29 3:37 ` Chao Leng
2021-01-26 8:15 ` [PATCH v4 5/5] nvme-fc: " Chao Leng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15301bba-f7db-a0c9-c7fa-6efaafefd21c@huawei.com \
--to=lengchao@huawei.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox