From: Sagi Grimberg <sagi@grimberg.me>
To: Chao Leng <lengchao@huawei.com>, linux-nvme@lists.infradead.org
Cc: kbusch@kernel.org, axboe@fb.com, linux-block@vger.kernel.org,
hch@lst.de, axboe@kernel.dk
Subject: Re: [PATCH v4 4/5] nvme-rdma: avoid IO error for nvme native multipath
Date: Thu, 28 Jan 2021 19:37:33 -0800 [thread overview]
Message-ID: <a55689cc-0925-c3a3-b7bf-e155cc3d4fe9@grimberg.me> (raw)
In-Reply-To: <b5b70392-d4f7-6f0c-d337-a6023dc4b992@huawei.com>
>>> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
>>> index b7ce4f221d99..66b697461bd9 100644
>>> --- a/drivers/nvme/host/rdma.c
>>> +++ b/drivers/nvme/host/rdma.c
>>> @@ -2084,8 +2084,13 @@ static blk_status_t nvme_rdma_queue_rq(struct
>>> blk_mq_hw_ctx *hctx,
>>>
>>> err = nvme_rdma_post_send(queue, sqe, req->sge, req->num_sge,
>>> req->mr ? &req->reg_wr.wr : NULL);
>>> - if (unlikely(err))
>>> + if (unlikely(err)) {
>>> + if (err == -EIO) {
>>> + nvme_complete_failed_rq(rq,
>>> NVME_SC_HOST_PATH_ERROR);
>>
>> I was thinking about:
>> --
>> err = nvme_rdma_post_send(queue, sqe, req->sge, req->num_sge,
>> req->mr ? &req->reg_wr.wr : NULL);
>> if (unlikely(err)) {
>> if (err == -EIO) {
>> /*
>> * Fail the reuqest so upper layer can
>> failover I/O
>> * if another path is available
>> */
>> req->status = NVME_SC_HOST_PATH_ERROR;
>> nvme_rdma_complete_rq(rq);
>> return BLK_STS_OK;Need to do clean. so can
>> not directly return.
The completion path cleans up though
>>
>> }
>> goto err_unmap;
>> }
>> --
>> .
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-29 3:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 8:15 [PATCH v4 0/5] avoid double request completion and IO error Chao Leng
2021-01-26 8:15 ` [PATCH v4 1/5] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-01-27 16:40 ` Christoph Hellwig
2021-01-28 1:34 ` Chao Leng
2021-01-26 8:15 ` [PATCH v4 2/5] nvme-core: introduce complete failed request Chao Leng
2021-01-26 8:15 ` [PATCH v4 3/5] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command Chao Leng
2021-01-26 8:15 ` [PATCH v4 4/5] nvme-rdma: avoid IO error for nvme native multipath Chao Leng
2021-01-28 8:39 ` Sagi Grimberg
2021-01-28 9:31 ` Chao Leng
2021-01-29 1:35 ` Sagi Grimberg
2021-01-29 2:48 ` Chao Leng
2021-01-29 3:24 ` Sagi Grimberg
2021-01-29 3:30 ` Chao Leng
2021-01-29 3:37 ` Sagi Grimberg [this message]
2021-01-29 3:50 ` Chao Leng
2021-01-29 3:37 ` Chao Leng
2021-01-26 8:15 ` [PATCH v4 5/5] nvme-fc: " Chao Leng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55689cc-0925-c3a3-b7bf-e155cc3d4fe9@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox