From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH 3/4] NVMe: Fix double free irq
Date: Mon, 22 Dec 2014 10:15:21 -0500 [thread overview]
Message-ID: <20141222151521.GI2220@wil.cx> (raw)
In-Reply-To: <1419036856-16275-4-git-send-email-keith.busch@intel.com>
On Fri, Dec 19, 2014@05:54:15PM -0700, Keith Busch wrote:
> Sets the vector to an invalid value after it's freed so we don't free
> it twice.
>
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/block/nvme-core.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
> index b1d5d87..9642c83 100644
> --- a/drivers/block/nvme-core.c
> +++ b/drivers/block/nvme-core.c
> @@ -106,7 +106,7 @@ struct nvme_queue {
> dma_addr_t cq_dma_addr;
> u32 __iomem *q_db;
> u16 q_depth;
> - u16 cq_vector;
> + int cq_vector;
If you're going to change its size, can you move it up one slot so as
to not leave a hole? The 'pahole' tool can tell you when there are holes
in structures.
next prev parent reply other threads:[~2014-12-22 15:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 0:54 [PATCH 0/4] nvme-blkmq fixes Keith Busch
2014-12-20 0:54 ` [PATCH 1/4] blk-mq: Exit queue on alloc failure Keith Busch
2014-12-20 0:54 ` [PATCH 2/4] blk-mq: Export freeze/unfreeze functions Keith Busch
2014-12-20 0:54 ` [PATCH 3/4] NVMe: Fix double free irq Keith Busch
2014-12-22 15:15 ` Matthew Wilcox [this message]
2014-12-20 0:54 ` [PATCH 4/4] NVMe: Freeze queues on shutdown Keith Busch
2014-12-20 17:32 ` [PATCH 0/4] nvme-blkmq fixes Jens Axboe
2014-12-20 19:29 ` Jens Axboe
2014-12-22 16:38 ` Keith Busch
2014-12-22 16:47 ` Jens Axboe
2014-12-22 18:17 ` Keith Busch
2014-12-22 18:19 ` Jens Axboe
2014-12-22 20:08 ` Jens Axboe
2014-12-22 21:01 ` Keith Busch
2014-12-23 1:34 ` Keith Busch
2014-12-23 17:49 ` Jens Axboe
2014-12-23 17:54 ` Jens Axboe
2014-12-23 18:09 ` Keith Busch
2014-12-23 21:10 ` Keith Busch
2014-12-23 21:23 ` Keith Busch
2014-12-23 21:24 ` Jens Axboe
2014-12-31 2:31 ` Keith Busch
2014-12-31 16:38 ` Jens Axboe
2015-01-05 15:17 ` Keith Busch
2015-01-05 19:30 ` Jens Axboe
2015-01-05 20:19 ` Keith Busch
2015-01-05 20:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222151521.GI2220@wil.cx \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox