From: axboe@fb.com (Jens Axboe)
Subject: [PATCH 0/4] nvme-blkmq fixes
Date: Wed, 31 Dec 2014 09:38:34 -0700 [thread overview]
Message-ID: <54A4268A.6030504@fb.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1412310215470.4026@localhost.lm.intel.com>
On 12/30/2014 07:31 PM, Keith Busch wrote:
> Abandon the whole series... Too many corner cases where this falls
> to pieces. I'm running high queue-depth IO with random error injection
> that causes requests to get on lists from ctx->rq_list, hctx->dispatch,
> and q->requeue_list. No matter what I do from the driver, there is
> always a case in either reset or removal where a requests get lost and
> blk_cleanup_queue never completes.
Back to the drawing board, I'll drop the series. Still off from work
here, I'll take a look when I get back soon. I'm surprised it's this
difficult, we already went through most of this design/test hash out
with scsi-mq.
I'll drop this one:
NVMe: Freeze queues on shutdown
but keep this one:
NVMe: Fix double free irq
Agree?
--
Jens Axboe
next prev parent reply other threads:[~2014-12-31 16:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 0:54 [PATCH 0/4] nvme-blkmq fixes Keith Busch
2014-12-20 0:54 ` [PATCH 1/4] blk-mq: Exit queue on alloc failure Keith Busch
2014-12-20 0:54 ` [PATCH 2/4] blk-mq: Export freeze/unfreeze functions Keith Busch
2014-12-20 0:54 ` [PATCH 3/4] NVMe: Fix double free irq Keith Busch
2014-12-22 15:15 ` Matthew Wilcox
2014-12-20 0:54 ` [PATCH 4/4] NVMe: Freeze queues on shutdown Keith Busch
2014-12-20 17:32 ` [PATCH 0/4] nvme-blkmq fixes Jens Axboe
2014-12-20 19:29 ` Jens Axboe
2014-12-22 16:38 ` Keith Busch
2014-12-22 16:47 ` Jens Axboe
2014-12-22 18:17 ` Keith Busch
2014-12-22 18:19 ` Jens Axboe
2014-12-22 20:08 ` Jens Axboe
2014-12-22 21:01 ` Keith Busch
2014-12-23 1:34 ` Keith Busch
2014-12-23 17:49 ` Jens Axboe
2014-12-23 17:54 ` Jens Axboe
2014-12-23 18:09 ` Keith Busch
2014-12-23 21:10 ` Keith Busch
2014-12-23 21:23 ` Keith Busch
2014-12-23 21:24 ` Jens Axboe
2014-12-31 2:31 ` Keith Busch
2014-12-31 16:38 ` Jens Axboe [this message]
2015-01-05 15:17 ` Keith Busch
2015-01-05 19:30 ` Jens Axboe
2015-01-05 20:19 ` Keith Busch
2015-01-05 20:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A4268A.6030504@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox