[PATCH] nvme_fc: add message on final controller removal

[PATCH] nvme_fc: add message on final controller removal

[James Smart]

Given disparity between class level delete and transport delete,
add an info message when the transport controller object deletes.

Signed-off-by: James Smart <james.smart at broadcom.com>
---
 drivers/nvme/host/fc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 2748a84cec3a..c70aa0975361 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -1817,6 +1817,8 @@ nvme_fc_ctrl_free(struct kref *ref)
 		container_of(ref, struct nvme_fc_ctrl, ref);
 	unsigned long flags;
 
+	dev_info(ctrl->dev, "NVME-FC{%d}: Controller Removed\n", ctrl->cnum);
+
 	if (ctrl->ctrl.tagset) {
 		blk_cleanup_queue(ctrl->ctrl.connect_q);
 		blk_mq_free_tag_set(&ctrl->tag_set);
-- 
2.13.1

[PATCH] nvme_fc: add message on final controller removal

[Christoph Hellwig]

On Tue, Sep 19, 2017@02:02:10PM -0700, James Smart wrote:
> Given disparity between class level delete and transport delete,
> add an info message when the transport controller object deletes.

Hmm.  Why do we need this in the FC code?

[PATCH] nvme_fc: add message on final controller removal

[James Smart]

On 9/20/2017 2:32 PM, Christoph Hellwig wrote:
> On Tue, Sep 19, 2017@02:02:10PM -0700, James Smart wrote:
>> Given disparity between class level delete and transport delete,
>> add an info message when the transport controller object deletes.
> 
> Hmm.  Why do we need this in the FC code?
> 

It's a debug aid. I'm finding all the transitions spit out messages 
saying controller is deleting, which makes the admin think it's deleted. 
But what really happened was the delete calls were made to the core 
routines, but those routines are getting hung up in ns teardown. So 
admins are reporting things as "deleted" when they really aren't yet. 
This message just book-ends the initial deleting messages.

it could certainly go in the core nvme_free_ctrl() call before it calls 
the transport free routine.

-- james